Przeglądaj źródła

LibWeb: Don't collapse blocks into the previous sibling's padding

We were forgetting to account for the padding-bottom of the previous
relevant sibling when placing blocks vertically.
Andreas Kling 4 lat temu
rodzic
commit
6f74eaed42
1 zmienionych plików z 1 dodań i 1 usunięć
  1. 1 1
      Libraries/LibWeb/Layout/LayoutBlock.cpp

+ 1 - 1
Libraries/LibWeb/Layout/LayoutBlock.cpp

@@ -647,7 +647,7 @@ void LayoutBlock::place_block_level_non_replaced_element_in_normal_flow(LayoutBl
     }
 
     if (relevant_sibling) {
-        y += relevant_sibling->effective_offset().y() + relevant_sibling->height();
+        y += relevant_sibling->effective_offset().y() + relevant_sibling->height() + relevant_sibling->box_model().padding.bottom.to_px(*relevant_sibling);
 
         // Collapse top margin with bottom margin of preceding siblings if needed
         float my_margin_top = box.margin.top.to_px(*this);