0ct0pu5/ladybird
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions 2

LibJS: Use more specific return types for some Temporal AOs

Browse source 
Instead of returning Object* we should be specific and return Instant*,
TimeZone* etc.
This commit is contained in:
Linus Groh 2021-07-14 20:52:15 +01:00
parent be475cd6a8
commit 6c8f0fbb35
Notes: sideshowbarker 2024-07-18 09:00:42 +09:00
4 changed files with 6 additions and 6 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
Userland/Libraries/LibJS/Runtime/Temporal/Now.cpp
View file

@ -45,7 +45,7 @@ JS_DEFINE_NATIVE_FUNCTION(Now::instant)
}
// 2.2.1 SystemTimeZone ( ), https://tc39.es/proposal-temporal/#sec-temporal-systemtimezone
Object* system_time_zone(GlobalObject& global_object)
TimeZone* system_time_zone(GlobalObject& global_object)
{
// 1. Let identifier be ! DefaultTimeZone().
auto identifier = default_time_zone();
@ -78,7 +78,7 @@ BigInt* system_utc_epoch_nanoseconds(GlobalObject& global_object)
}
// 2.2.3 SystemInstant ( )
Object* system_instant(GlobalObject& global_object)
Instant* system_instant(GlobalObject& global_object)
{
// 1. Let ns be ! SystemUTCEpochNanoseconds().
auto* ns = system_utc_epoch_nanoseconds(global_object);

4
Userland/Libraries/LibJS/Runtime/Temporal/Now.h
View file

@ -23,8 +23,8 @@ private:
JS_DECLARE_NATIVE_FUNCTION(instant);
};
Object* system_time_zone(GlobalObject&);
TimeZone* system_time_zone(GlobalObject&);
BigInt* system_utc_epoch_nanoseconds(GlobalObject&);
Object* system_instant(GlobalObject&);
Instant* system_instant(GlobalObject&);
}

2
Userland/Libraries/LibJS/Runtime/Temporal/TimeZone.cpp
View file

@ -60,7 +60,7 @@ String default_time_zone()
}
// 11.6.2 CreateTemporalTimeZone ( identifier [ , newTarget ] ), https://tc39.es/proposal-temporal/#sec-temporal-createtemporaltimezone
Object* create_temporal_time_zone(GlobalObject& global_object, String const& identifier, FunctionObject* new_target)
TimeZone* create_temporal_time_zone(GlobalObject& global_object, String const& identifier, FunctionObject* new_target)
{
auto& vm = global_object.vm();

2
Userland/Libraries/LibJS/Runtime/Temporal/TimeZone.h
View file

@ -38,7 +38,7 @@ private:
bool is_valid_time_zone_name(String const& time_zone);
String canonicalize_time_zone_name(String const& time_zone);
String default_time_zone();
Object* create_temporal_time_zone(GlobalObject&, String const& identifier, FunctionObject* new_target = nullptr);
TimeZone* create_temporal_time_zone(GlobalObject&, String const& identifier, FunctionObject* new_target = nullptr);
double parse_time_zone_offset_string(GlobalObject&, String const&);
String format_time_zone_offset_string(double offset_nanoseconds);