LibJS: Implement Iterator.prototype.some

Author: https://github.com/trflynn89
Commit: https://github.com/SerenityOS/serenity/commit/6ac1d5afae
Pull-request: https://github.com/SerenityOS/serenity/pull/19642

Userland/Libraries/LibJS/Runtime/IteratorPrototype.cpp

@@ -39,6 +39,7 @@ ThrowCompletionOr<void> IteratorPrototype::initialize(Realm& realm)
     define_native_function(realm, vm.names.reduce, reduce, 1, attr);
     define_native_function(realm, vm.names.toArray, to_array, 0, attr);
     define_native_function(realm, vm.names.forEach, for_each, 1, attr);
+    define_native_function(realm, vm.names.some, some, 1, attr);
 
     return {};
 }
@@ -594,4 +595,51 @@ JS_DEFINE_NATIVE_FUNCTION(IteratorPrototype::for_each)
     }
 }
 
+// 3.1.3.10 Iterator.prototype.some ( predicate ), https://tc39.es/proposal-iterator-helpers/#sec-iteratorprototype.some
+JS_DEFINE_NATIVE_FUNCTION(IteratorPrototype::some)
+{
+    auto predicate = vm.argument(0);
+
+    // 1. Let O be the this value.
+    // 2. If O is not an Object, throw a TypeError exception.
+    auto object = TRY(this_object(vm));
+
+    // 3. If IsCallable(predicate) is false, throw a TypeError exception.
+    if (!predicate.is_function())
+        return vm.throw_completion<TypeError>(ErrorType::NotAFunction, "predicate"sv);
+
+    // 4. Let iterated be ? GetIteratorDirect(O).
+    auto iterated = TRY(get_iterator_direct(vm, object));
+
+    // 5. Let counter be 0.
+    size_t counter = 0;
+
+    // 6. Repeat,
+    while (true) {
+        // a. Let next be ? IteratorStep(iterated).
+        auto next = TRY(iterator_step(vm, iterated));
+
+        // b. If next is false, return false.
+        if (!next)
+            return Value { false };
+
+        // c. Let value be ? IteratorValue(next).
+        auto value = TRY(iterator_value(vm, *next));
+
+        // d. Let result be Completion(Call(predicate, undefined, « value, 𝔽(counter) »)).
+        auto result = call(vm, predicate.as_function(), js_undefined(), value, Value { counter });
+
+        // e. IfAbruptCloseIterator(result, iterated).
+        if (result.is_error())
+            return *TRY(iterator_close(vm, iterated, result.release_error()));
+
+        // f. If ToBoolean(result) is true, return ? IteratorClose(iterated, NormalCompletion(true)).
+        if (result.value().to_boolean())
+            return *TRY(iterator_close(vm, iterated, normal_completion(Value { true })));
+
+        // g. Set counter to counter + 1.
+        ++counter;
+    }
+}
+
 }

Userland/Libraries/LibJS/Runtime/IteratorPrototype.h

@@ -30,6 +30,7 @@ private:
     JS_DECLARE_NATIVE_FUNCTION(reduce);
     JS_DECLARE_NATIVE_FUNCTION(to_array);
     JS_DECLARE_NATIVE_FUNCTION(for_each);
+    JS_DECLARE_NATIVE_FUNCTION(some);
 };
 
 }

Userland/Libraries/LibJS/Tests/builtins/Iterator/Iterator.prototype.some.js

@@ -0,0 +1,113 @@
+describe("errors", () => {
+    test("called with non-callable object", () => {
+        expect(() => {
+            Iterator.prototype.some(Symbol.hasInstance);
+        }).toThrowWithMessage(TypeError, "predicate is not a function");
+    });
+
+    test("iterator's next method throws", () => {
+        function TestError() {}
+
+        class TestIterator extends Iterator {
+            next() {
+                throw new TestError();
+            }
+        }
+
+        expect(() => {
+            new TestIterator().some(() => 0);
+        }).toThrow(TestError);
+    });
+
+    test("value returned by iterator's next method throws", () => {
+        function TestError() {}
+
+        class TestIterator extends Iterator {
+            next() {
+                return {
+                    done: false,
+                    get value() {
+                        throw new TestError();
+                    },
+                };
+            }
+        }
+
+        expect(() => {
+            new TestIterator().some(() => 0);
+        }).toThrow(TestError);
+    });
+
+    test("predicate function throws", () => {
+        function TestError() {}
+
+        class TestIterator extends Iterator {
+            next() {
+                return {
+                    done: false,
+                    value: 1,
+                };
+            }
+        }
+
+        expect(() => {
+            new TestIterator().some(() => {
+                throw new TestError();
+            });
+        }).toThrow(TestError);
+    });
+});
+
+describe("normal behavior", () => {
+    test("length is 1", () => {
+        expect(Iterator.prototype.some).toHaveLength(1);
+    });
+
+    test("predicate function can see every value", () => {
+        function* generator() {
+            yield "a";
+            yield "b";
+        }
+
+        let count = 0;
+
+        const result = generator().some((value, index) => {
+            ++count;
+
+            switch (index) {
+                case 0:
+                    expect(value).toBe("a");
+                    break;
+                case 1:
+                    expect(value).toBe("b");
+                    break;
+                default:
+                    expect().fail(`Unexpected reducer invocation: value=${value} index=${index}`);
+                    break;
+            }
+
+            return false;
+        });
+
+        expect(count).toBe(2);
+        expect(result).toBeFalse();
+    });
+
+    test("iteration stops when predicate returns true", () => {
+        function* generator() {
+            yield "a";
+            yield "b";
+            yield "c";
+        }
+
+        let count = 0;
+
+        const result = generator().some(value => {
+            ++count;
+            return value === "b";
+        });
+
+        expect(count).toBe(2);
+        expect(result).toBeTrue();
+    });
+});