WebContent: Pass the script timeout into the WebDriver script executor
This was dropped in0b9803d
and31469ee
before the timeouts object was avaiable in WebContent.
This commit is contained in:
parent
04f41bda52
commit
6a55370401
Notes:
sideshowbarker
2024-07-17 07:20:49 +09:00
Author: https://github.com/trflynn89 Commit: https://github.com/SerenityOS/serenity/commit/6a55370401 Pull-request: https://github.com/SerenityOS/serenity/pull/16033 Reviewed-by: https://github.com/linusg ✅
1 changed files with 2 additions and 4 deletions
|
@ -900,8 +900,7 @@ Messages::WebDriverClient::ExecuteScriptResponse WebDriverConnection::execute_sc
|
|||
// FIXME: 3. Handle any user prompts, and return its value if it is an error.
|
||||
|
||||
// 4., 5.1-5.3.
|
||||
// FIXME: Move timeouts from WebDriver to WebContent and pass the script timeout through here.
|
||||
auto result = Web::WebDriver::execute_script(m_page_host.page(), body, move(arguments), {});
|
||||
auto result = Web::WebDriver::execute_script(m_page_host.page(), body, move(arguments), m_timeouts_configuration.script_timeout);
|
||||
dbgln_if(WEBDRIVER_DEBUG, "Executing script returned: {}", result.value);
|
||||
|
||||
switch (result.type) {
|
||||
|
@ -932,8 +931,7 @@ Messages::WebDriverClient::ExecuteAsyncScriptResponse WebDriverConnection::execu
|
|||
// FIXME: 3. Handle any user prompts, and return its value if it is an error.
|
||||
|
||||
// 4., 5.1-5.11.
|
||||
// FIXME: Move timeouts from WebDriver to WebContent and pass the script timeout through here.
|
||||
auto result = Web::WebDriver::execute_async_script(m_page_host.page(), body, move(arguments), {});
|
||||
auto result = Web::WebDriver::execute_async_script(m_page_host.page(), body, move(arguments), m_timeouts_configuration.script_timeout);
|
||||
dbgln_if(WEBDRIVER_DEBUG, "Executing async script returned: {}", result.value);
|
||||
|
||||
switch (result.type) {
|
||||
|
|
Loading…
Add table
Reference in a new issue