Prechádzať zdrojové kódy

Kernel: Tidy up InodeWatcher construction

- Rename create() => try_create()
- Use adopt_nonnull_ref_or_enomem()
Andreas Kling 3 rokov pred
rodič
commit
68a6d4c30a

+ 2 - 5
Kernel/FileSystem/InodeWatcher.cpp

@@ -12,12 +12,9 @@
 
 namespace Kernel {
 
-KResultOr<NonnullRefPtr<InodeWatcher>> InodeWatcher::create()
+KResultOr<NonnullRefPtr<InodeWatcher>> InodeWatcher::try_create()
 {
-    auto watcher = adopt_ref_if_nonnull(new (nothrow) InodeWatcher);
-    if (watcher)
-        return watcher.release_nonnull();
-    return ENOMEM;
+    return adopt_nonnull_ref_or_enomem(new (nothrow) InodeWatcher);
 }
 
 InodeWatcher::~InodeWatcher()

+ 1 - 1
Kernel/FileSystem/InodeWatcher.h

@@ -43,7 +43,7 @@ private:
 
 class InodeWatcher final : public File {
 public:
-    static KResultOr<NonnullRefPtr<InodeWatcher>> create();
+    static KResultOr<NonnullRefPtr<InodeWatcher>> try_create();
     virtual ~InodeWatcher() override;
 
     virtual bool can_read(const FileDescription&, size_t) const override;

+ 1 - 1
Kernel/Syscalls/inode_watcher.cpp

@@ -23,7 +23,7 @@ KResultOr<FlatPtr> Process::sys$create_inode_watcher(u32 flags)
         return fd_or_error.error();
     auto inode_watcher_fd = fd_or_error.release_value();
 
-    auto watcher_or_error = InodeWatcher::create();
+    auto watcher_or_error = InodeWatcher::try_create();
     if (watcher_or_error.is_error())
         return watcher_or_error.error();