Browse Source

AK: Remove a redundant double find-call in HashMap::ensure

If the value was found there's no reason to search for it again.
Idan Horowitz 3 years ago
parent
commit
679bde06ed
1 changed files with 8 additions and 5 deletions
  1. 8 5
      AK/HashMap.h

+ 8 - 5
AK/HashMap.h

@@ -134,8 +134,10 @@ public:
     V& ensure(const K& key)
     V& ensure(const K& key)
     {
     {
         auto it = find(key);
         auto it = find(key);
-        if (it == end())
-            set(key, V());
+        if (it != end())
+            return it->value;
+        auto result = set(key, V());
+        VERIFY(result == HashSetResult::InsertedNewEntry);
         return find(key)->value;
         return find(key)->value;
     }
     }
 
 
@@ -143,9 +145,10 @@ public:
     V& ensure(K const& key, Callback initialization_callback)
     V& ensure(K const& key, Callback initialization_callback)
     {
     {
         auto it = find(key);
         auto it = find(key);
-        if (it == end()) {
-            set(key, initialization_callback());
-        }
+        if (it != end())
+            return it->value;
+        auto result = set(key, initialization_callback());
+        VERIFY(result == HashSetResult::InsertedNewEntry);
         return find(key)->value;
         return find(key)->value;
     }
     }