Browse Source

Kernel: Zero-initialize LocalSocket::m_address

It was possible to read uninitialized kernel memory via getsockname().
Of course, kmalloc() is a good boy and scrubs new allocations with 0xBB
so all you got was a bunch of 0xBB.
Andreas Kling 5 years ago
parent
commit
67950c80c8
1 changed files with 1 additions and 1 deletions
  1. 1 1
      Kernel/Net/LocalSocket.h

+ 1 - 1
Kernel/Net/LocalSocket.h

@@ -91,7 +91,7 @@ private:
 
     bool m_bound { false };
     bool m_accept_side_fd_open { false };
-    sockaddr_un m_address;
+    sockaddr_un m_address { 0, { 0 } };
 
     DoubleBuffer m_for_client;
     DoubleBuffer m_for_server;