From 6781d60e3acb253c1544e1fe976311d7e6064d8f Mon Sep 17 00:00:00 2001 From: Brian Gianforcaro Date: Sun, 10 Oct 2021 00:06:13 -0700 Subject: [PATCH] LibWeb: Use "= default" to declare empty constructors and descructors A types which have special functions declared with "= default can be trivially copied. Besides being good practice, the compiler might be able generate copy and initialize code in a more optimized way. Found By PVS-Studio: https://pvs-studio.com/en/docs/warnings/v832/ --- Userland/Libraries/LibWeb/CSS/MediaQuery.h | 4 ++-- Userland/Libraries/LibWeb/DOM/Window.cpp | 2 +- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/Userland/Libraries/LibWeb/CSS/MediaQuery.h b/Userland/Libraries/LibWeb/CSS/MediaQuery.h index 93215252275..0e4e3fad65c 100644 --- a/Userland/Libraries/LibWeb/CSS/MediaQuery.h +++ b/Userland/Libraries/LibWeb/CSS/MediaQuery.h @@ -20,7 +20,7 @@ class MediaQuery : public RefCounted { friend class Parser; public: - ~MediaQuery() { } + ~MediaQuery() = default; // https://www.w3.org/TR/mediaqueries-4/#media-types enum class MediaType { @@ -82,7 +82,7 @@ public: String to_string() const; private: - MediaQuery() { } + MediaQuery() = default; // https://www.w3.org/TR/mediaqueries-4/#mq-not bool m_negated { false }; diff --git a/Userland/Libraries/LibWeb/DOM/Window.cpp b/Userland/Libraries/LibWeb/DOM/Window.cpp index 8c2d1f7a743..2fe22feb6be 100644 --- a/Userland/Libraries/LibWeb/DOM/Window.cpp +++ b/Userland/Libraries/LibWeb/DOM/Window.cpp @@ -31,7 +31,7 @@ public: , m_handler(move(handler)) { } - ~RequestAnimationFrameCallback() { } + ~RequestAnimationFrameCallback() = default; i32 id() const { return m_id; } bool is_cancelled() const { return !m_handler; }