فهرست منبع

LibWeb: Don't subtract dubious "line spacing" from line y offsets

I'm not sure what this was trying to achieve, but it was moving all
line fragments upwards and a lot of things look a lot better if we
just stop doing that.
Andreas Kling 4 سال پیش
والد
کامیت
66a053da77
1فایلهای تغییر یافته به همراه1 افزوده شده و 2 حذف شده
  1. 1 2
      Libraries/LibWeb/Layout/InlineFormattingContext.cpp

+ 1 - 2
Libraries/LibWeb/Layout/InlineFormattingContext.cpp

@@ -113,7 +113,6 @@ void InlineFormattingContext::run(LayoutMode layout_mode)
 
     auto text_align = containing_block.style().text_align();
     float min_line_height = containing_block.specified_style().line_height(containing_block);
-    float line_spacing = min_line_height - containing_block.specified_style().font().glyph_height();
     float content_height = 0;
     float max_linebox_width = 0;
 
@@ -166,7 +165,7 @@ void InlineFormattingContext::run(LayoutMode layout_mode)
 
             // Vertically align everyone's bottom to the line.
             // FIXME: Support other kinds of vertical alignment.
-            fragment.set_offset({ roundf(x_offset + fragment.offset().x()), content_height + (max_height - fragment.height()) - (line_spacing / 2) });
+            fragment.set_offset({ roundf(x_offset + fragment.offset().x()), content_height + (max_height - fragment.height()) });
 
             if (text_align == CSS::TextAlign::Justify
                 && fragment.is_justifiable_whitespace()