Kaynağa Gözat

Shell: Don't do null check on `NonnullRefPtr<T>`

This will cause a problem when `NonnullRefPtr<T>::operator T*` will be
declared as RETURNS_NONNULL. Clang emits a warning for this pointless
null check, which breaks CI.
Daniel Bertalan 4 yıl önce
ebeveyn
işleme
65b2d3add3
1 değiştirilmiş dosya ile 1 ekleme ve 1 silme
  1. 1 1
      Userland/Shell/AST.cpp

+ 1 - 1
Userland/Shell/AST.cpp

@@ -1775,7 +1775,7 @@ RefPtr<Value> IfCond::run(RefPtr<Shell> shell)
 {
 {
     auto cond = m_condition->run(shell)->resolve_without_cast(shell);
     auto cond = m_condition->run(shell)->resolve_without_cast(shell);
     // The condition could be a builtin, in which case it has already run and exited.
     // The condition could be a builtin, in which case it has already run and exited.
-    if (cond && cond->is_job()) {
+    if (cond->is_job()) {
         auto cond_job_value = static_cast<const JobValue*>(cond.ptr());
         auto cond_job_value = static_cast<const JobValue*>(cond.ptr());
         auto cond_job = cond_job_value->job();
         auto cond_job = cond_job_value->job();