0ct0pu5/ladybird
1
0
Fork 0
mirror of https://github.com/LadybirdBrowser/ladybird.git synced 2024-12-12 09:20:36 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 7

AK+ProtocolServer: Properly close download stream fd's

Browse source 
This makes the issue of running out of openable pipes in the
ProtocolServer process much less likely (but still possible).
This commit is contained in:
AnotherTest 2020-12-30 21:05:54 +03:30 committed by Andreas Kling
parent bdd4b99d72
commit 6422a04cda
Notes: sideshowbarker 2024-07-19 00:21:38 +09:00 
Author: https://github.com/alimpfard
Commit: https://github.com/SerenityOS/serenity/commit/6422a04cdae
Pull-request: https://github.com/SerenityOS/serenity/pull/4665
2 changed files with 5 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

3
AK/FileStream.h
View file

@ -54,8 +54,9 @@ public:
~InputFileStream()
{
if (m_file) {
fflush(m_file);
if (m_owned)
fflush(m_file);
fclose(m_file);
}
}

4
Services/ProtocolServer/ClientConnection.cpp
View file

@ -72,7 +72,9 @@ OwnPtr<Messages::ProtocolServer::StartDownloadResponse> ClientConnection::handle
auto id = download->id();
auto fd = download->download_fd();
m_downloads.set(id, move(download));
return make<Messages::ProtocolServer::StartDownloadResponse>(id, fd);
auto response = make<Messages::ProtocolServer::StartDownloadResponse>(id, fd);
response->on_destruction = [fd] { close(fd); };
return response;
}
OwnPtr<Messages::ProtocolServer::StopDownloadResponse> ClientConnection::handle(const Messages::ProtocolServer::StopDownload& message)