We use cookies to ensure you get the best experience on our website
Ana Sayfa Keşfet Yardım
Üye Ol Giriş Yap
0ct0pu5
/
ladybird
1
0
Çatalla 0
Dosyalar Sorunlar 0 Değişiklik İstekleri 0 Wiki
Kaynağa Gözat

LibWeb: Ensure normal line-height on `HTMLInputElement`

Previously, setting CSS `line-height: 0` on an `input` element would
result in no text being displayed.

Other browsers handle this by setting the minimum height to the
"normal" value for single line inputs.
rmg-x 1 yıl önce
ebeveyn
b36a78a798
işleme
629068c2a7
3 değiştirilmiş dosya ile 32 ekleme ve 0 silme
Birleşik Görünüm Farklılık Durumunu Göster
  1. 19 0
      Tests/LibWeb/Layout/expected/css-line-height-zero.txt
  2. 5 0
      Tests/LibWeb/Layout/input/css-line-height-zero.html
  3. 8 0
      Userland/Libraries/LibWeb/HTML/HTMLInputElement.cpp

+ 19 - 0
Tests/LibWeb/Layout/expected/css-line-height-zero.txt
Dosyayı Görüntüle 

@@ -0,0 +1,19 @@
 
+Viewport <#document> at (0,0) content-size 800x600 children: not-inline
 
+  BlockContainer <html> at (0,0) content-size 800x37 [BFC] children: not-inline
 
+    BlockContainer <body> at (8,8) content-size 784x21 children: inline
 
+      frag 0 from BlockContainer start: 0, length: 0, rect: [9,9 191.875x19] baseline: 13.296875
 
+      BlockContainer <input> at (9,9) content-size 191.875x19 inline-block [BFC] children: not-inline
 
+        Box <div> at (11,10) content-size 187.875x17 flex-container(row) [FFC] children: not-inline
 
+          BlockContainer <div> at (11,10) content-size 187.875x17 flex-item [BFC] children: inline
 
+            frag 0 from TextNode start: 0, length: 11, rect: [11,10 91.953125x17] baseline: 13.296875
 
+                "Hello World"
 
+            TextNode <#text>
 
+      TextNode <#text>
 
+
 
+ViewportPaintable (Viewport<#document>) [0,0 800x600]
 
+  PaintableWithLines (BlockContainer<HTML>) [0,0 800x37]
 
+    PaintableWithLines (BlockContainer<BODY>) [8,8 784x21]
 
+      PaintableWithLines (BlockContainer<INPUT>) [8,8 193.875x21]
 
+        PaintableBox (Box<DIV>) [9,9 191.875x19]
 
+          PaintableWithLines (BlockContainer<DIV>) [11,10 187.875x17]
 
+            TextPaintable (TextNode<#text>)

+ 5 - 0
Tests/LibWeb/Layout/input/css-line-height-zero.html
Dosyayı Görüntüle 

@@ -0,0 +1,5 @@
 
+<!DOCTYPE html><html><head><style>
 
+    input {
 
+      line-height: 0;
 
+    }
 
+  </style></head><body><input type="text" value="Hello World">

+ 8 - 0
Userland/Libraries/LibWeb/HTML/HTMLInputElement.cpp
Dosyayı Görüntüle 

@@ -127,6 +127,14 @@ void HTMLInputElement::adjust_computed_style(CSS::StyleProperties& style)
 
         if (style.property(CSS::PropertyID::Width)->has_auto())
 
         if (style.property(CSS::PropertyID::Width)->has_auto())
 
             style.set_property(CSS::PropertyID::Width, CSS::LengthStyleValue::create(CSS::Length(size(), CSS::Length::Type::Ch)));
 
             style.set_property(CSS::PropertyID::Width, CSS::LengthStyleValue::create(CSS::Length(size(), CSS::Length::Type::Ch)));
 
     }
 
     }
 
+
 
+    // NOTE: The following line-height check is done for web compatability and usability reasons.
 
+    // FIXME: The "normal" line-height value should be calculated but assume 1.0 for now.
 
+    double normal_line_height = 1.0;
 
+    double current_line_height = style.line_height().to_double();
 
+
 
+    if (is_single_line() && current_line_height < normal_line_height)
 
+        style.set_property(CSS::PropertyID::LineHeight, CSS::IdentifierStyleValue::create(CSS::ValueID::Normal));
 
 }
 
 }
 
 
 
 void HTMLInputElement::set_checked(bool checked, ChangeSource change_source)
 
 void HTMLInputElement::set_checked(bool checked, ChangeSource change_source)

Contact | Legal | Takedown | Status
Self-hosted public services - About
NibbleSpot by 0ct0pu5