0ct0pu5/ladybird
1
0
Fork 0
mirror of https://github.com/LadybirdBrowser/ladybird.git synced 2024-12-03 04:50:29 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 10

LibWeb: Pass through sample rate in OfflineAudioContext constructor

Browse source 
I can't actually spot in the spec where it explicitly says to pass this
through (unlike the AudioContext constructor) - but clearly this needs
to be passed through for an OfflineAudioContext to actually have a
sample rate!
This commit is contained in:
Shannon Booth 2024-05-02 00:03:32 +12:00 committed by Andreas Kling
parent 303958a803
commit 5f57596520
Notes: sideshowbarker 2024-07-17 04:49:48 +09:00 
Author: https://github.com/shannonbooth
Commit: https://github.com/SerenityOS/serenity/commit/5f57596520
Pull-request: https://github.com/SerenityOS/serenity/pull/24195
3 changed files with 4 additions and 4 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

3
Userland/Libraries/LibWeb/WebAudio/BaseAudioContext.cpp
View file

@ -13,8 +13,9 @@
namespace Web::WebAudio {
BaseAudioContext::BaseAudioContext(JS::Realm& realm)
BaseAudioContext::BaseAudioContext(JS::Realm& realm, float sample_rate)
: DOM::EventTarget(realm)
, m_sample_rate(sample_rate)
{
}

2
Userland/Libraries/LibWeb/WebAudio/BaseAudioContext.h
View file

@ -50,7 +50,7 @@ public:
WebIDL::ExceptionOr<JS::NonnullGCPtr<OscillatorNode>> create_oscillator();
protected:
explicit BaseAudioContext(JS::Realm&);
explicit BaseAudioContext(JS::Realm&, float m_sample_rate = 0);
virtual void initialize(JS::Realm&) override;

3
Userland/Libraries/LibWeb/WebAudio/OfflineAudioContext.cpp
View file

@ -73,11 +73,10 @@ OfflineAudioContext::OfflineAudioContext(JS::Realm& realm, OfflineAudioContextOp
}
OfflineAudioContext::OfflineAudioContext(JS::Realm& realm, WebIDL::UnsignedLong number_of_channels, WebIDL::UnsignedLong length, float sample_rate)
: BaseAudioContext(realm)
: BaseAudioContext(realm, sample_rate)
, m_length(length)
{
(void)number_of_channels;
(void)sample_rate;
}
void OfflineAudioContext::initialize(JS::Realm& realm)