Browse Source

LibWeb: Pass cookie string by reference in Document::set_cookie

This string is only taken by const reference internally, so there's no
point in forcing the callers to copy the string.
Idan Horowitz 3 năm trước cách đây
mục cha
commit
5e5b94a7ec

+ 1 - 1
Userland/Libraries/LibWeb/DOM/Document.cpp

@@ -1006,7 +1006,7 @@ String Document::cookie(Cookie::Source source)
     return {};
     return {};
 }
 }
 
 
-void Document::set_cookie(String cookie_string, Cookie::Source source)
+void Document::set_cookie(String const& cookie_string, Cookie::Source source)
 {
 {
     auto cookie = Cookie::parse_cookie(cookie_string);
     auto cookie = Cookie::parse_cookie(cookie_string);
     if (!cookie.has_value())
     if (!cookie.has_value())

+ 1 - 1
Userland/Libraries/LibWeb/DOM/Document.h

@@ -56,7 +56,7 @@ public:
     virtual ~Document() override;
     virtual ~Document() override;
 
 
     String cookie(Cookie::Source = Cookie::Source::NonHttp);
     String cookie(Cookie::Source = Cookie::Source::NonHttp);
-    void set_cookie(String, Cookie::Source = Cookie::Source::NonHttp);
+    void set_cookie(String const&, Cookie::Source = Cookie::Source::NonHttp);
 
 
     String referrer() const;
     String referrer() const;