0ct0pu5/ladybird
1
0
Fork 0
mirror of https://github.com/LadybirdBrowser/ladybird.git synced 2024-12-24 23:23:58 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 8

LibJS: Treat missing arg in Array.prototype.includes() as undefined

Browse source
This commit is contained in:
Linus Groh 2020-05-21 20:50:53 +01:00 committed by Andreas Kling
parent fbcfc8dcd0
commit 5db9becc4a
Notes: sideshowbarker 2024-07-19 06:16:17 +09:00 
Author: https://github.com/linusg
Commit: https://github.com/SerenityOS/serenity/commit/5db9becc4a5
Pull-request: https://github.com/SerenityOS/serenity/pull/2324
Reviewed-by: https://github.com/Dexesttp
2 changed files with 4 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
Libraries/LibJS/Runtime/ArrayPrototype.cpp
View file

@ -422,8 +422,8 @@ Value ArrayPrototype::includes(Interpreter& interpreter)
if (!array)
return {};
i32 array_size = static_cast<i32>(array->elements().size());
if (interpreter.argument_count() == 0 || array_size == 0)
i32 array_size = array->elements().size();
if (array_size == 0)
return Value(false);
i32 from_index = 0;

2
Libraries/LibJS/Tests/Array.prototype.includes.js
View file

@ -5,6 +5,8 @@ try {
var array = ['hello', 'friends', 1, 2, false];
assert([].includes() === false);
assert([undefined].includes() === true);
assert(array.includes('hello') === true);
assert(array.includes(1) === true);
assert(array.includes(1, -3) === true);