0ct0pu5/ladybird
1
0
Fork 0
mirror of https://github.com/LadybirdBrowser/ladybird.git synced 2024-12-04 05:20:30 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 7

AK: Zero previous pointer *after* fixing the insertion list in HashTable

Browse source
This commit is contained in:
Hendiadyoin1 2022-06-23 17:00:41 +02:00 committed by Idan Horowitz
parent f03838fac8
commit 5bf84a5b0e
Notes: sideshowbarker 2024-07-17 10:01:25 +09:00 
Author: https://github.com/Hendiadyoin1
Commit: https://github.com/SerenityOS/serenity/commit/5bf84a5b0e
Pull-request: https://github.com/SerenityOS/serenity/pull/14363
Reviewed-by: https://github.com/IdanHo
2 changed files with 10 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
AK/HashTable.h
View file

@ -704,11 +704,11 @@ private:
bucket.previous->next = bucket.next;
else
m_collection_data.head = bucket.next;
bucket.previous = nullptr;
if (bucket.next)
bucket.next->previous = bucket.previous;
else
m_collection_data.tail = bucket.previous;
bucket.previous = nullptr;
bucket.next = nullptr;
}
}

9
Tests/AK/TestHashTable.cpp
View file

@ -300,3 +300,12 @@ BENCHMARK_CASE(benchmark_thrashing)
table.remove(i);
}
}
TEST_CASE(reinsertion)
{
OrderedHashTable<String> map;
map.set("ytidb::LAST_RESULT_ENTRY_KEY");
map.set("__sak");
map.remove("__sak");
map.set("__sak");
}