0ct0pu5/ladybird
1
0
Fork 0
mirror of https://github.com/LadybirdBrowser/ladybird.git synced 2024-12-11 17:00:37 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 7

LibWeb: Only reload iframe on src/srcdoc attribute changes, not all

Browse source 
Fixes Cloudflare Turnstile suddenly going blank and stopping when it
changes the style attribute after doing some setup on the iframe.
This commit is contained in:
Luke Wilde 2024-01-01 16:31:14 +00:00 committed by Andreas Kling
parent 6eeda29642
commit 5af058d2b6
Notes: sideshowbarker 2024-07-17 02:28:18 +09:00 
Author: https://github.com/Lubrsi
Commit: https://github.com/SerenityOS/serenity/commit/5af058d2b6
Pull-request: https://github.com/SerenityOS/serenity/pull/22529
3 changed files with 118 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

10
Tests/LibWeb/Text/expected/HTML/iframe-reload-on-src-or-srcdoc-change.txt Normal file
View file

@ -0,0 +1,10 @@
1
2
4
5
6
8
9
11
12
DONE

97
Tests/LibWeb/Text/input/HTML/iframe-reload-on-src-or-srcdoc-change.html Normal file
View file

@ -0,0 +1,97 @@
<iframe id="test-iframe"></iframe>
<script src="../include.js"></script>
<script>
asyncTest((done) => {
window.addEventListener("message", (e) => {
println(e.data);
if (e.data === "DONE")
done();
});
let testCount = 1;
function createTest(asBlob, final = false) {
let html = `
&lt;script&gt;
parent.postMessage(${testCount++}, "*");
${final ? "parent.postMessage('DONE', '*')" : ""}
&lt;/script&gt;
`;
html = html.replaceAll("&lt;", "<").replaceAll("&gt;", ">");
return asBlob
? URL.createObjectURL(new Blob([html], { type: "text/html" }))
: html;
}
// https://html.spec.whatwg.org/multipage/iframe-embed-object.html#the-iframe-element:process-the-iframe-attributes-2
// https://html.spec.whatwg.org/multipage/iframe-embed-object.html#the-iframe-element:process-the-iframe-attributes-3
// Whenever an iframe element with a non-null content navigable has its srcdoc attribute set, changed, or removed,
// the user agent must process the iframe attributes.
// Similarly, whenever an iframe element with a non-null content navigable but with no srcdoc attribute specified
// has its src attribute set, changed, or removed, the user agent must process the iframe attributes.
const firstSrcdoc = createTest(false);
const testIframe = document.getElementById("test-iframe");
testIframe.addEventListener("load", () => {
switch (testCount)
{
case 2:
// Change srcdoc.
testIframe.srcdoc = createTest(false);
break;
case 3:
// Remove srcdoc.
testIframe.removeAttribute("srcdoc");
testCount++;
// FIXME: Do this in test case 4. However, it does not work currently as the navigation to
// about:blank following srcdoc does not fire a load event.
// Set src.
testIframe.src = createTest(true);
break;
case 5:
// Change src.
testIframe.src = createTest(true);
break;
case 6:
// srcdoc takes priority.
testIframe.srcdoc = createTest(false);
break;
case 7:
// Changing src has no effect when srcdoc is specified.
testIframe.src = createTest(true);
setTimeout(() => {
testIframe.srcdoc = createTest(false);
}, 0)
break;
case 9:
// Removing src has no effect when srcdoc is specified.
testIframe.removeAttribute("src");
setTimeout(() => {
testIframe.srcdoc = createTest(false);
}, 0);
break;
case 10:
// Setting src has no effect when srcdoc is specified.
testIframe.src = createTest(true);
setTimeout(() => {
testIframe.srcdoc = createTest(false);
}, 0);
break;
case 12:
// Changing any other attributes doesn't cause a reload.
testIframe.setAttribute("data-hello", "world");
setTimeout(() => {
testIframe.srcdoc = createTest(false, true);
}, 0);
break;
default:
break;
}
});
// Set srcdoc.
testIframe.srcdoc = firstSrcdoc;
});
</script>

13
Userland/Libraries/LibWeb/HTML/HTMLIFrameElement.cpp
View file

@ -39,8 +39,17 @@ JS::GCPtr<Layout::Node> HTMLIFrameElement::create_layout_node(NonnullRefPtr<CSS:
void HTMLIFrameElement::attribute_changed(FlyString const& name, Optional<String> const& value)
{
HTMLElement::attribute_changed(name, value);
if (m_content_navigable)
process_the_iframe_attributes();
// https://html.spec.whatwg.org/multipage/iframe-embed-object.html#the-iframe-element:process-the-iframe-attributes-2
// https://html.spec.whatwg.org/multipage/iframe-embed-object.html#the-iframe-element:process-the-iframe-attributes-3
// Whenever an iframe element with a non-null content navigable has its srcdoc attribute set, changed, or removed,
// the user agent must process the iframe attributes.
// Similarly, whenever an iframe element with a non-null content navigable but with no srcdoc attribute specified
// has its src attribute set, changed, or removed, the user agent must process the iframe attributes.
if (m_content_navigable) {
if (name == AttributeNames::srcdoc || (name == AttributeNames::src && !has_attribute(AttributeNames::srcdoc)))
process_the_iframe_attributes();
}
}
// https://html.spec.whatwg.org/multipage/iframe-embed-object.html#the-iframe-element:the-iframe-element-6