0ct0pu5/ladybird
1
0
Fork 0
mirror of https://github.com/LadybirdBrowser/ladybird.git synced 2024-12-12 09:20:36 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 7

Kernel: Remove useless partition UUID length check

Browse source 
UUID::to_string() always returns a string of length 36, so this check
can't fail.
This commit is contained in:
Idan Horowitz 2022-02-15 20:54:13 +02:00 committed by Andreas Kling
parent 9277d2dce2
commit 5a5766be2c
Notes: sideshowbarker 2024-07-17 18:41:22 +09:00 
Author: https://github.com/IdanHo
Commit: https://github.com/SerenityOS/serenity/commit/5a5766be2c
Pull-request: https://github.com/SerenityOS/serenity/pull/12564
Reviewed-by: https://github.com/MaxWipfli
1 changed files with 0 additions and 6 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

6
Kernel/Storage/StorageManagement.cpp
View file

@ -222,12 +222,6 @@ UNMAP_AFTER_INIT void StorageManagement::determine_boot_device_with_partition_uu
auto partition_uuid = UUID(m_boot_argument.substring_view(partition_uuid_prefix.length()), UUID::Endianness::Mixed);
if (partition_uuid.to_string().length() != 36) {
// FIXME: It would be helpful to output the specified and detected UUIDs in this case,
// but we never actually enter this path - if the length doesn't match, the UUID
// constructor above crashes with a VERIFY in convert_string_view_to_uuid().
PANIC("StorageManagement: Specified partition UUID is not valid");
}
for (auto& storage_device : m_storage_devices) {
for (auto& partition : storage_device.partitions()) {
if (partition.metadata().unique_guid().is_zero())