0ct0pu5/ladybird
1
0
Fork 0
mirror of https://github.com/LadybirdBrowser/ladybird.git synced 2024-12-25 15:39:55 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 9

DisplayProperties: Wallpaper tab now has preview

Browse source 
As was mentioned in #556, the `DisplayProperties` Wallpaper tab
contained a lot of "extra space", in which half the tab was taken up
by the list of wallpapers. The rest of that space is now reserved for
a wallpaper preview, so the user can see the selected image before
applying it.
This commit is contained in:
Jesse Buhagiar 2019-09-14 19:22:32 +10:00 committed by Andreas Kling
parent f44e7dc5d0
commit 58ceaebd5a
Notes: sideshowbarker 2024-07-19 12:06:50 +09:00 
Author: https://github.com/Quaker762
Commit: https://github.com/SerenityOS/serenity/commit/58ceaebd5ae
Pull-request: https://github.com/SerenityOS/serenity/pull/561
Reviewed-by: https://github.com/awesomekling
1 changed files with 10 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

12
Applications/DisplayProperties/DisplayProperties.cpp
View file

@ -1,5 +1,6 @@
#include <AK/StringBuilder.h> #include <AK/StringBuilder.h>
#include <LibCore/CDirIterator.h> #include <LibCore/CDirIterator.h>
#include <LibDraw/PNGLoader.h>
#include <LibGUI/GAction.h> #include <LibGUI/GAction.h>
#include <LibGUI/GApplication.h> #include <LibGUI/GApplication.h>
#include <LibGUI/GBoxLayout.h> #include <LibGUI/GBoxLayout.h>
@ -8,6 +9,7 @@
#include <LibGUI/GEventLoop.h> #include <LibGUI/GEventLoop.h>
#include <LibGUI/GFileSystemModel.h> #include <LibGUI/GFileSystemModel.h>
#include <LibGUI/GGroupBox.h> #include <LibGUI/GGroupBox.h>
#include <LibGUI/GLabel.h>
#include <LibGUI/GListView.h> #include <LibGUI/GListView.h>
#include <LibGUI/GScrollBar.h> #include <LibGUI/GScrollBar.h>
#include <LibGUI/GSplitter.h> #include <LibGUI/GSplitter.h>
@ -72,15 +74,21 @@ void DisplayPropertiesWidget::create_frame()
auto* background_content = new GWidget(background_splitter); auto* background_content = new GWidget(background_splitter);
background_content->set_layout(make<GBoxLayout>(Orientation::Vertical)); background_content->set_layout(make<GBoxLayout>(Orientation::Vertical));
background_content->layout()->add_spacer();
background_content->layout()->set_margins({ 4, 4, 4, 4 }); background_content->layout()->set_margins({ 4, 4, 4, 4 });
auto* wallpaper_preview = new GLabel(background_splitter);
auto* wallpaper_list = new GListView(background_content); auto* wallpaper_list = new GListView(background_content);
wallpaper_list->set_background_color(Color::White); wallpaper_list->set_background_color(Color::White);
wallpaper_list->set_model(*ItemListModel<AK::String>::create(m_wallpapers)); wallpaper_list->set_model(*ItemListModel<AK::String>::create(m_wallpapers));
wallpaper_list->horizontal_scrollbar().set_visible(false); wallpaper_list->horizontal_scrollbar().set_visible(false);
wallpaper_list->on_selection = [this](auto& index) { wallpaper_list->on_selection = [this, wallpaper_preview](auto& index) {
StringBuilder builder;
m_selected_wallpaper = m_wallpapers.at(index.row()); m_selected_wallpaper = m_wallpapers.at(index.row());
builder.append("/res/wallpapers/");
builder.append(m_selected_wallpaper);
wallpaper_preview->set_icon(load_png(builder.to_string()));
wallpaper_preview->set_should_stretch_icon(true);
}; };
// Let's add the settings tab // Let's add the settings tab