Parcourir la source

LibJS/Bytecode: Turn UnaryMinus(NumericLiteral) into a constant

Andreas Kling il y a 1 an
Parent
commit
56a3ccde1a
1 fichiers modifiés avec 8 ajouts et 0 suppressions
  1. 8 0
      Userland/Libraries/LibJS/Bytecode/ASTCodegen.cpp

+ 8 - 0
Userland/Libraries/LibJS/Bytecode/ASTCodegen.cpp

@@ -269,6 +269,14 @@ Bytecode::CodeGenerationErrorOr<Optional<ScopedOperand>> LogicalExpression::gene
 Bytecode::CodeGenerationErrorOr<Optional<ScopedOperand>> UnaryExpression::generate_bytecode(Bytecode::Generator& generator, Optional<ScopedOperand> preferred_dst) const
 {
     Bytecode::Generator::SourceLocationScope scope(generator, *this);
+
+    // OPTIMIZATION: Turn expressions like `-1` into a constant.
+    if (m_op == UnaryOp::Minus && is<NumericLiteral>(*m_lhs)) {
+        auto& numeric_literal = static_cast<NumericLiteral const&>(*m_lhs);
+        auto value = numeric_literal.value();
+        return generator.add_constant(Value(-value.as_double()));
+    }
+
     if (m_op == UnaryOp::Delete)
         return generator.emit_delete_reference(m_lhs);