0ct0pu5/ladybird
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions 2

LibWeb: Use the correct document URL in DOMParser.parseFromString()

Browse source 
We were hard-coding "about:blank" as the document URL for parsed HTML
documents, which was definitely not correct.

This fixes a bunch of WPT tests under /domparsing/ :^)
This commit is contained in:
Andreas Kling 2024-10-17 11:49:21 +02:00 • committed by Andreas Kling
parent 323370dfa3
commit 55f58eea99
Notes: github-actions[bot] 2024-10-17 17:17:10 +00:00
3 changed files with 22 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
Tests/LibWeb/Text/expected/HTML/DOMParser-parseFromString-document-url.txt Normal file
View file

@ -0,0 +1,2 @@
PASS text/html
PASS application/xhtml+xml

19
Tests/LibWeb/Text/input/HTML/DOMParser-parseFromString-document-url.html Normal file
View file

@ -0,0 +1,19 @@
<script src="../include.js"></script>
<script>
test(() => {
const parser = new DOMParser();
for (const mimeType of ["text/html", "application/xhtml+xml"]) {
const doc = parser.parseFromString("<html><b>hello", mimeType);
if (doc.URL == "about:blank") {
println("FAIL 1 " + mimeType);
} else if (!doc.URL.endsWith(".html")) {
println("FAIL 2 " + mimeType);
} else if (doc.URL == document.URL) {
println("PASS " + mimeType);
} else {
println("FAIL 3 " + mimeType);
}
}
});
</script>

3
Userland/Libraries/LibWeb/DOM/Document.cpp
View file

@ -5415,8 +5415,7 @@ void Document::parse_html_from_a_string(StringView html)
auto parser = HTML::HTMLParser::create(*this, html, "UTF-8"sv);
// 4. Start parser and let it run until it has consumed all the characters just inserted into the input stream.
// FIXME: This is to match the default URL. Instead, pass in this's relevant global object's associated Document's URL.
parser->run("about:blank"sv);
parser->run(verify_cast<HTML::Window>(HTML::relevant_global_object(*this)).associated_document().url());
}
// https://html.spec.whatwg.org/multipage/dynamic-markup-insertion.html#dom-parsehtmlunsafe