0ct0pu5/ladybird
1
0
Fork 0
mirror of https://github.com/LadybirdBrowser/ladybird.git synced 2024-12-14 02:10:36 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 7

LibWeb+WebContent: Support displaying favicons in OOPWV

Browse source 
In single process mode, the browser will display a page's favicon in
both the location bar and tab. This adds the same support for multi-
process mode.
This commit is contained in:
Timothy Flynn 2021-03-26 10:41:25 -04:00 committed by Andreas Kling
parent ff0d4c6f7c
commit 557927f25b
Notes: sideshowbarker 2024-07-18 21:04:16 +09:00 
Author: https://github.com/trflynn89 🔰
Commit: https://github.com/SerenityOS/serenity/commit/557927f25b9
Pull-request: https://github.com/SerenityOS/serenity/pull/5958
7 changed files with 24 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

6
Userland/Libraries/LibWeb/OutOfProcessWebView.cpp
View file

@ -335,6 +335,12 @@ void OutOfProcessWebView::notify_server_did_js_console_output(const String& meth
on_js_console_output(method, line);
}
void OutOfProcessWebView::notify_server_did_change_favicon(const Gfx::Bitmap& favicon)
{
if (on_favicon_change)
on_favicon_change(favicon);
}
void OutOfProcessWebView::did_scroll()
{
client().post_message(Messages::WebContentServer::SetViewportRect(visible_content_rect()));

1
Userland/Libraries/LibWeb/OutOfProcessWebView.h
View file

@ -75,6 +75,7 @@ public:
String notify_server_did_request_prompt(Badge<WebContentClient>, const String& message, const String& default_);
void notify_server_did_get_source(const URL& url, const String& source);
void notify_server_did_js_console_output(const String& method, const String& line);
void notify_server_did_change_favicon(const Gfx::Bitmap& favicon);
private:
OutOfProcessWebView();

9
Userland/Libraries/LibWeb/WebContentClient.cpp
View file

@ -173,4 +173,13 @@ OwnPtr<Messages::WebContentClient::DidRequestPromptResponse> WebContentClient::h
return make<Messages::WebContentClient::DidRequestPromptResponse>(result);
}
void WebContentClient::handle(const Messages::WebContentClient::DidChangeFavicon& message)
{
if (!message.favicon().is_valid()) {
dbgln("DidChangeFavicon: Received invalid favicon");
return;
}
m_view.notify_server_did_change_favicon(*message.favicon().bitmap());
}
}

1
Userland/Libraries/LibWeb/WebContentClient.h
View file

@ -68,6 +68,7 @@ private:
virtual void handle(const Messages::WebContentClient::DidRequestLinkContextMenu&) override;
virtual void handle(const Messages::WebContentClient::DidGetSource&) override;
virtual void handle(const Messages::WebContentClient::DidJSConsoleOutput&) override;
virtual void handle(const Messages::WebContentClient::DidChangeFavicon&) override;
virtual OwnPtr<Messages::WebContentClient::DidRequestAlertResponse> handle(const Messages::WebContentClient::DidRequestAlert&) override;
virtual OwnPtr<Messages::WebContentClient::DidRequestConfirmResponse> handle(const Messages::WebContentClient::DidRequestConfirm&) override;
virtual OwnPtr<Messages::WebContentClient::DidRequestPromptResponse> handle(const Messages::WebContentClient::DidRequestPrompt&) override;

5
Userland/Services/WebContent/PageHost.cpp
View file

@ -188,4 +188,9 @@ String PageHost::page_did_request_prompt(const String& message, const String& de
return m_client.send_sync<Messages::WebContentClient::DidRequestPrompt>(message, default_)->response();
}
void PageHost::page_did_change_favicon(const Gfx::Bitmap& favicon)
{
m_client.post_message(Messages::WebContentClient::DidChangeFavicon(favicon.to_shareable_bitmap()));
}
}

1
Userland/Services/WebContent/PageHost.h
View file

@ -72,6 +72,7 @@ private:
virtual void page_did_request_alert(const String&) override;
virtual bool page_did_request_confirm(const String&) override;
virtual String page_did_request_prompt(const String&, const String&) override;
virtual void page_did_change_favicon(const Gfx::Bitmap&) override;
explicit PageHost(ClientConnection&);

1
Userland/Services/WebContent/WebContentClient.ipc
View file

@ -21,4 +21,5 @@ endpoint WebContentClient = 90
DidRequestPrompt(String message, String default_) => (String response)
DidGetSource(URL url, String source) =|
DidJSConsoleOutput(String method, String line) =|
DidChangeFavicon(Gfx::ShareableBitmap favicon) =|
}