Sfoglia il codice sorgente

DevTools: Mark compilation-unit-only functions as static

This enables a nice warning in case a function becomes dead code. Also, in case
of signal_trampoline_dummy, marking it external (non-static) prevents it from
being 'optimized away', which would lead to surprising and weird linker errors.
Ben Wiederhake 5 anni fa
parent
commit
5574d45eda
2 ha cambiato i file con 4 aggiunte e 2 eliminazioni
  1. 1 1
      DevTools/Profiler/main.cpp
  2. 3 1
      DevTools/UserspaceEmulator/Emulator.cpp

+ 1 - 1
DevTools/Profiler/main.cpp

@@ -132,7 +132,7 @@ int main(int argc, char** argv)
     return app->exec();
 }
 
-bool prompt_to_stop_profiling()
+static bool prompt_to_stop_profiling()
 {
     auto window = GUI::Window::construct();
     window->set_title("Profiling");

+ 3 - 1
DevTools/UserspaceEmulator/Emulator.cpp

@@ -1124,7 +1124,7 @@ enum class DefaultSignalAction {
     Continue,
 };
 
-DefaultSignalAction default_signal_action(int signal)
+static DefaultSignalAction default_signal_action(int signal)
 {
     ASSERT(signal && signal < NSIG);
 
@@ -1235,6 +1235,8 @@ void report(const char* format, ...)
     va_end(ap);
 }
 
+// Make sure the compiler doesn't "optimize away" this function:
+extern void signal_trampoline_dummy(void);
 void signal_trampoline_dummy(void)
 {
     // The trampoline preserves the current eax, pushes the signal code and