0ct0pu5/ladybird
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions 2

WebContent: Add double buffering to the WebContentView

Browse source 
This removes the remaining flicker in the WebContentView widget and
makes it feel pretty good to use it. :^)

The increase in memory use is something we'll have to address in the
future with more sophisticated solutions like tiling, etc.
This commit is contained in:
Andreas Kling 2020-07-05 16:31:50 +02:00
parent 668fe61b1d
commit 554b58d85f
Notes: sideshowbarker 2024-07-19 05:08:09 +09:00
2 changed files with 15 additions and 9 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

21
Demos/WebView/WebContentView.cpp
View file

@ -55,18 +55,21 @@ void WebContentView::paint_event(GUI::PaintEvent& event)
painter.add_clip_rect(event.rect()); painter.add_clip_rect(event.rect());
painter.translate(frame_thickness(), frame_thickness()); painter.translate(frame_thickness(), frame_thickness());
ASSERT(m_bitmap); ASSERT(m_front_bitmap);
painter.blit({ 0, 0 }, *m_bitmap, m_bitmap->rect()); painter.blit({ 0, 0 }, *m_front_bitmap, m_front_bitmap->rect());
} }
void WebContentView::resize_event(GUI::ResizeEvent& event) void WebContentView::resize_event(GUI::ResizeEvent& event)
{ {
GUI::ScrollableWidget::resize_event(event); GUI::ScrollableWidget::resize_event(event);
auto bitmap = Gfx::Bitmap::create(Gfx::BitmapFormat::RGB32, available_size()); m_front_bitmap = Gfx::Bitmap::create(Gfx::BitmapFormat::RGB32, available_size())->to_bitmap_backed_by_shared_buffer();
m_bitmap = bitmap->to_bitmap_backed_by_shared_buffer(); m_front_bitmap->shared_buffer()->share_with(client().server_pid());
m_bitmap->shared_buffer()->share_with(client().server_pid());
client().post_message(Messages::WebContentServer::SetViewportRect(Gfx::IntRect({ horizontal_scrollbar().value(), vertical_scrollbar().value() }, m_bitmap->size()))); m_back_bitmap = Gfx::Bitmap::create(Gfx::BitmapFormat::RGB32, available_size())->to_bitmap_backed_by_shared_buffer();
m_back_bitmap->shared_buffer()->share_with(client().server_pid());
client().post_message(Messages::WebContentServer::SetViewportRect(Gfx::IntRect({ horizontal_scrollbar().value(), vertical_scrollbar().value() }, available_size())));
request_repaint(); request_repaint();
} }
@ -87,9 +90,11 @@ void WebContentView::mousemove_event(GUI::MouseEvent& event)
void WebContentView::notify_server_did_paint(Badge<WebContentClient>, i32 shbuf_id) void WebContentView::notify_server_did_paint(Badge<WebContentClient>, i32 shbuf_id)
{ {
if (m_bitmap->shbuf_id() == shbuf_id) if (m_back_bitmap->shbuf_id() == shbuf_id) {
swap(m_back_bitmap, m_front_bitmap);
update(); update();
} }
}
void WebContentView::notify_server_did_invalidate_content_rect(Badge<WebContentClient>, [[maybe_unused]] const Gfx::IntRect& content_rect) void WebContentView::notify_server_did_invalidate_content_rect(Badge<WebContentClient>, [[maybe_unused]] const Gfx::IntRect& content_rect)
{ {
@ -128,7 +133,7 @@ void WebContentView::did_scroll()
void WebContentView::request_repaint() void WebContentView::request_repaint()
{ {
client().post_message(Messages::WebContentServer::Paint(m_bitmap->rect().translated(horizontal_scrollbar().value(), vertical_scrollbar().value()), m_bitmap->shbuf_id())); client().post_message(Messages::WebContentServer::Paint(m_back_bitmap->rect().translated(horizontal_scrollbar().value(), vertical_scrollbar().value()), m_back_bitmap->shbuf_id()));
} }
WebContentClient& WebContentView::client() WebContentClient& WebContentView::client()

3
Demos/WebView/WebContentView.h
View file

@ -66,5 +66,6 @@ private:
WebContentClient& client(); WebContentClient& client();
RefPtr<WebContentClient> m_client; RefPtr<WebContentClient> m_client;
RefPtr<Gfx::Bitmap> m_bitmap; RefPtr<Gfx::Bitmap> m_front_bitmap;
RefPtr<Gfx::Bitmap> m_back_bitmap;
}; };