0ct0pu5/ladybird
1
0
Fork 0
mirror of https://github.com/LadybirdBrowser/ladybird.git synced 2024-12-04 05:20:30 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 7

LibPDF: Reject non-hexdigits in hex string with error

Browse source 
...instead of VERIFY()ing input data.

I haven't seen this in the wild, but since I'm here anyways,
might as well fix this.
This commit is contained in:
Nico Weber 2023-10-25 00:09:50 -07:00 committed by Andreas Kling
parent 4675700057
commit 54cdcd0d06
Notes: sideshowbarker 2024-07-16 21:34:08 +09:00 
Author: https://github.com/nico
Commit: https://github.com/SerenityOS/serenity/commit/54cdcd0d06
Pull-request: https://github.com/SerenityOS/serenity/pull/21585
1 changed files with 3 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
Userland/Libraries/LibPDF/Parser.cpp
View file

@ -380,7 +380,9 @@ PDFErrorOr<DeprecatedString> Parser::parse_hex_string()
builder.append(static_cast<char>(hex_value));
return builder.to_deprecated_string();
}
VERIFY(isxdigit(ch));
if (!isxdigit(ch))
return error("character in hex string isn't hex digit");
hex_value *= 16;
if (ch <= '9') {