0ct0pu5/ladybird
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions 2

LibHTML: Make the HTML parser handle <div attr> and <div attr="">

Browse source 
We were not producing the correct DOM attribute in either of those
cases. "<div attr>" would produce no attribute, and the other would
produce an attribute with null value (instead of an empty value.)
This commit is contained in:
Andreas Kling 2019-11-21 20:06:10 +01:00
parent bd857cd0fa
commit 54a6ae9201
Notes: sideshowbarker 2024-07-19 11:07:25 +09:00
1 changed files with 10 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

11
Libraries/LibHTML/Parser/HTMLParser.cpp
View file

@ -118,7 +118,15 @@ static bool parse_html_document(const StringView& html, Document& document, Pare
}; };
auto commit_attribute = [&] { auto commit_attribute = [&] {
attributes.append({ String::copy(attribute_name_buffer), String::copy(attribute_value_buffer) }); if (!attribute_name_buffer.is_empty()) {
auto name = String::copy(attribute_name_buffer);
String value;
if (attribute_value_buffer.is_empty())
value = String::empty();
else
value = String::copy(attribute_value_buffer);
attributes.empend(name, value);
}
}; };
for (int i = 0; i < html.length(); ++i) { for (int i = 0; i < html.length(); ++i) {
@ -243,6 +251,7 @@ static bool parse_html_document(const StringView& html, Document& document, Pare
} }
if (ch == '>') { if (ch == '>') {
commit_attribute();
commit_tag(); commit_tag();
move_to_state(State::Free); move_to_state(State::Free);
break; break;