Selaa lähdekoodia

LibWeb: Explain discrepancy with media-query parsing

This had me confused for a while, but I am not smart enough today to
actually fix it properly. :^)
Sam Atkins 3 vuotta sitten
vanhempi
commit
53ec2ace23
1 muutettua tiedostoa jossa 3 lisäystä ja 0 poistoa
  1. 3 0
      Userland/Libraries/LibWeb/CSS/Parser/Parser.cpp

+ 3 - 0
Userland/Libraries/LibWeb/CSS/Parser/Parser.cpp

@@ -1124,6 +1124,9 @@ OwnPtr<MediaCondition> Parser::parse_media_in_parens(TokenStream<StyleComponentV
     }
 
     // `<general-enclosed>`
+    // FIXME: We should only be taking this branch if the grammar doesn't match the above options.
+    //        Currently we take it if the above fail to parse, which is different.
+    //        eg, `@media (min-width: 76yaks)` is valid grammar, but does not parse because `yaks` isn't a unit.
     if (auto maybe_general_enclosed = parse_general_enclosed(tokens); maybe_general_enclosed.has_value())
         return MediaCondition::from_general_enclosed(maybe_general_enclosed.release_value());