0ct0pu5/ladybird
1
0
Fork 0
mirror of https://github.com/LadybirdBrowser/ladybird.git synced 2024-12-11 17:00:37 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 7

StringView: Implement find_first_of in terms of AK::find

Browse source 
Problem:
- The implementation of `find_first_of` is coupled to the
  implementation of `StringView`.

Solution:
- Decouple the implementation of `find_first_of` from the class by
  using a generic `find` algorithm.
This commit is contained in:
Lenny Maiorani 2021-01-14 15:48:01 -07:00 committed by Andreas Kling
parent d11727ff28
commit 53afdc0106
Notes: sideshowbarker 2024-07-18 23:51:47 +09:00 
Author: https://github.com/ldm5180
Commit: https://github.com/SerenityOS/serenity/commit/53afdc0106f
Pull-request: https://github.com/SerenityOS/serenity/pull/4952
1 changed files with 13 additions and 9 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

22
AK/StringView.cpp
View file

@ -24,7 +24,9 @@
* OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
*/
#include <AK/AnyOf.h>
#include <AK/ByteBuffer.h>
#include <AK/Find.h>
#include <AK/FlyString.h>
#include <AK/Memory.h>
#include <AK/String.h>
@ -270,21 +272,23 @@ bool StringView::operator==(const String& string) const
Optional<size_t> StringView::find_first_of(char c) const
{
for (size_t pos = 0; pos < m_length; ++pos) {
if (m_characters[pos] == c)
return pos;
if (const auto location = AK::find(begin(), end(), c); location != end()) {
return location.index();
}
return {};
}
Optional<size_t> StringView::find_first_of(const StringView& view) const
{
for (size_t pos = 0; pos < m_length; ++pos) {
char c = m_characters[pos];
for (char view_char : view) {
if (c == view_char)
return pos;
}
if (const auto location = AK::find_if(begin(), end(),
[&](const auto c) {
return AK::any_of(view.begin(), view.end(),
[&](const auto view_char) {
return c == view_char;
});
});
location != end()) {
return location.index();
}
return {};
}