0ct0pu5/ladybird
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions 2

Kernel: Fix return value for {enable,disable}_profile_timer()

Browse source 
These functions should return success when being called when profiling
has been requested from multiple callers because enabling/disabling the
timer is a no-op in that case and thus didn't fail.
This commit is contained in:
Gunnar Beutner 2021-05-17 15:23:27 +02:00 • committed by Andreas Kling
parent e0493c509e
commit 52a4a1ec75
Notes: sideshowbarker 2024-07-18 17:55:21 +09:00
1 changed files with 10 additions and 10 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

20
Kernel/Time/TimeManagement.cpp
View file

@ -402,20 +402,20 @@ void TimeManagement::system_timer_tick(const RegisterState& regs)
bool TimeManagement::enable_profile_timer()
{
if (m_profile_timer && m_profile_enable_count.fetch_add(1) == 0) {
m_profile_timer->try_to_set_frequency(m_profile_timer->calculate_nearest_possible_frequency(OPTIMAL_PROFILE_TICKS_PER_SECOND_RATE));
return true;
}
return false;
if (!m_profile_timer)
return false;
if (m_profile_enable_count.fetch_add(1) == 0)
return m_profile_timer->try_to_set_frequency(m_profile_timer->calculate_nearest_possible_frequency(OPTIMAL_PROFILE_TICKS_PER_SECOND_RATE));
return true;
}
bool TimeManagement::disable_profile_timer()
{
if (m_profile_timer && m_profile_enable_count.fetch_sub(1) == 1) {
m_profile_timer->try_to_set_frequency(m_profile_timer->calculate_nearest_possible_frequency(1));
return true;
}
return false;
if (!m_profile_timer)
return false;
if (m_profile_enable_count.fetch_sub(1) == 1)
return m_profile_timer->try_to_set_frequency(m_profile_timer->calculate_nearest_possible_frequency(1));
return true;
}
}