0ct0pu5/ladybird
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions 2

ntpquery: Explicitly zero initialize msghdr and fill in fields

Browse source 
Rather than trying to use designated initializers, zero init the
msghdr variable and fill in its fields. This makes sure to zero-init any
padding bytes, and fixes a compilation error on musl-libc based systems.
This commit is contained in:
Andrew Kaster 2022-12-18 09:03:08 -07:00 • committed by Andreas Kling
parent 0d813ee519
commit 4ed5520e3e
Notes: sideshowbarker 2024-07-17 02:56:40 +09:00
1 changed files with 9 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

10
Userland/Utilities/ntpquery.cpp
View file

@ -187,7 +187,15 @@ ErrorOr<int> serenity_main(Main::Arguments arguments)
iovec iov { &packet, sizeof(packet) };
char control_message_buffer[CMSG_SPACE(sizeof(timeval))];
msghdr msg = { &peer_address, sizeof(peer_address), &iov, 1, control_message_buffer, sizeof(control_message_buffer), 0 };
msghdr msg = {};
msg.msg_name = &peer_address;
msg.msg_namelen = sizeof(peer_address);
msg.msg_iov = &iov;
msg.msg_iovlen = 1;
msg.msg_control = control_message_buffer;
msg.msg_controllen = sizeof(control_message_buffer);
msg.msg_flags = 0;
rc = recvmsg(fd, &msg, 0);
if (rc < 0) {
perror("recvmsg");