LibWeb: Add oncontrollerchange to ServiceWorkerContainer

Author: https://github.com/ADKaster
Commit: https://github.com/LadybirdBrowser/ladybird/commit/4df280689b5
Pull-request: https://github.com/LadybirdBrowser/ladybird/pull/1293
Reviewed-by: https://github.com/awesomekling

Userland/Libraries/LibWeb/HTML/EventNames.h

@@ -34,6 +34,7 @@ namespace Web::HTML::EventNames {
     __ENUMERATE_HTML_EVENT(close)                    \
     __ENUMERATE_HTML_EVENT(complete)                 \
     __ENUMERATE_HTML_EVENT(connect)                  \
+    __ENUMERATE_HTML_EVENT(controllerchange)         \
     __ENUMERATE_HTML_EVENT(contextmenu)              \
     __ENUMERATE_HTML_EVENT(copy)                     \
     __ENUMERATE_HTML_EVENT(cuechange)                \

Userland/Libraries/LibWeb/HTML/ServiceWorkerContainer.cpp

@@ -31,28 +31,17 @@ JS::NonnullGCPtr<ServiceWorkerContainer> ServiceWorkerContainer::create(JS::Real
     return realm.heap().allocate<ServiceWorkerContainer>(realm, realm);
 }
 
-// https://w3c.github.io/ServiceWorker/#dom-serviceworkercontainer-onmessage
-WebIDL::CallbackType* ServiceWorkerContainer::onmessage()
-{
-    return event_handler_attribute(HTML::EventNames::message);
-}
-
-// https://w3c.github.io/ServiceWorker/#dom-serviceworkercontainer-onmessage
-void ServiceWorkerContainer::set_onmessage(WebIDL::CallbackType* event_handler)
-{
-    set_event_handler_attribute(HTML::EventNames::message, event_handler);
-}
-
-// https://w3c.github.io/ServiceWorker/#dom-serviceworkercontainer-onmessageerror
-WebIDL::CallbackType* ServiceWorkerContainer::onmessageerror()
-{
-    return event_handler_attribute(HTML::EventNames::messageerror);
-}
-
-// https://w3c.github.io/ServiceWorker/#dom-serviceworkercontainer-onmessageerror
-void ServiceWorkerContainer::set_onmessageerror(WebIDL::CallbackType* event_handler)
-{
-    set_event_handler_attribute(HTML::EventNames::messageerror, event_handler);
-}
+#undef __ENUMERATE
+#define __ENUMERATE(attribute_name, event_name)                                    \
+    void ServiceWorkerContainer::set_##attribute_name(WebIDL::CallbackType* value) \
+    {                                                                              \
+        set_event_handler_attribute(event_name, move(value));                      \
+    }                                                                              \
+    WebIDL::CallbackType* ServiceWorkerContainer::attribute_name()                 \
+    {                                                                              \
+        return event_handler_attribute(event_name);                                \
+    }
+ENUMERATE_SERVICE_WORKER_CONTAINER_EVENT_HANDLERS(__ENUMERATE)
+#undef __ENUMERATE
 
 }

Userland/Libraries/LibWeb/HTML/ServiceWorkerContainer.h

@@ -9,6 +9,11 @@
 
 #include <LibWeb/DOM/EventTarget.h>
 
+#define ENUMERATE_SERVICE_WORKER_CONTAINER_EVENT_HANDLERS(E)  \
+    E(oncontrollerchange, HTML::EventNames::controllerchange) \
+    E(onmessage, HTML::EventNames::message)                   \
+    E(onmessageerror, HTML::EventNames::messageerror)
+
 namespace Web::HTML {
 
 class ServiceWorkerContainer : public DOM::EventTarget {
@@ -19,10 +24,12 @@ public:
     [[nodiscard]] static JS::NonnullGCPtr<ServiceWorkerContainer> create(JS::Realm& realm);
     virtual ~ServiceWorkerContainer() override = default;
 
-    WebIDL::CallbackType* onmessage();
-    void set_onmessage(WebIDL::CallbackType*);
-    WebIDL::CallbackType* onmessageerror();
-    void set_onmessageerror(WebIDL::CallbackType*);
+#undef __ENUMERATE
+#define __ENUMERATE(attribute_name, event_name)       \
+    void set_##attribute_name(WebIDL::CallbackType*); \
+    WebIDL::CallbackType* attribute_name();
+    ENUMERATE_SERVICE_WORKER_CONTAINER_EVENT_HANDLERS(__ENUMERATE)
+#undef __ENUMERATE
 
 private:
     explicit ServiceWorkerContainer(JS::Realm&);

Userland/Libraries/LibWeb/HTML/ServiceWorkerContainer.idl

@@ -17,7 +17,7 @@ interface ServiceWorkerContainer : EventTarget {
     [FIXME] undefined startMessages();
 
     // events
-    [FIXME] attribute EventHandler oncontrollerchange;
+    attribute EventHandler oncontrollerchange;
     attribute EventHandler onmessage; // event.source of message events is ServiceWorker object
     attribute EventHandler onmessageerror;
 };