Browse Source

LibJS: Convert ArrayIterator.prototype to be a PrototypeObject

Timothy Flynn 3 years ago
parent
commit
4d1d0f05a9

+ 9 - 13
Userland/Libraries/LibJS/Runtime/ArrayIteratorPrototype.cpp

@@ -6,7 +6,6 @@
 
 
 #include <LibJS/Runtime/AbstractOperations.h>
 #include <LibJS/Runtime/AbstractOperations.h>
 #include <LibJS/Runtime/Array.h>
 #include <LibJS/Runtime/Array.h>
-#include <LibJS/Runtime/ArrayIterator.h>
 #include <LibJS/Runtime/ArrayIteratorPrototype.h>
 #include <LibJS/Runtime/ArrayIteratorPrototype.h>
 #include <LibJS/Runtime/Error.h>
 #include <LibJS/Runtime/Error.h>
 #include <LibJS/Runtime/GlobalObject.h>
 #include <LibJS/Runtime/GlobalObject.h>
@@ -16,7 +15,7 @@
 namespace JS {
 namespace JS {
 
 
 ArrayIteratorPrototype::ArrayIteratorPrototype(GlobalObject& global_object)
 ArrayIteratorPrototype::ArrayIteratorPrototype(GlobalObject& global_object)
-    : Object(*global_object.iterator_prototype())
+    : PrototypeObject(*global_object.iterator_prototype())
 {
 {
 }
 }
 
 
@@ -39,21 +38,18 @@ ArrayIteratorPrototype::~ArrayIteratorPrototype()
 // FIXME: This seems to be CreateArrayIterator (https://tc39.es/ecma262/#sec-createarrayiterator) instead of %ArrayIteratorPrototype%.next.
 // FIXME: This seems to be CreateArrayIterator (https://tc39.es/ecma262/#sec-createarrayiterator) instead of %ArrayIteratorPrototype%.next.
 JS_DEFINE_NATIVE_FUNCTION(ArrayIteratorPrototype::next)
 JS_DEFINE_NATIVE_FUNCTION(ArrayIteratorPrototype::next)
 {
 {
-    auto this_value = vm.this_value(global_object);
-    if (!this_value.is_object() || !is<ArrayIterator>(this_value.as_object())) {
-        vm.throw_exception<TypeError>(global_object, ErrorType::NotAnObjectOfType, "Array Iterator");
+    auto* iterator = typed_this_value(global_object);
+    if (vm.exception())
         return {};
         return {};
-    }
-    auto& this_object = this_value.as_object();
-    auto& iterator = static_cast<ArrayIterator&>(this_object);
-    auto target_array = iterator.array();
+
+    auto target_array = iterator->array();
     if (target_array.is_undefined())
     if (target_array.is_undefined())
         return create_iterator_result_object(global_object, js_undefined(), true);
         return create_iterator_result_object(global_object, js_undefined(), true);
     VERIFY(target_array.is_object());
     VERIFY(target_array.is_object());
     auto& array = target_array.as_object();
     auto& array = target_array.as_object();
 
 
-    auto index = iterator.index();
-    auto iteration_kind = iterator.iteration_kind();
+    auto index = iterator->index();
+    auto iteration_kind = iterator->iteration_kind();
 
 
     size_t length;
     size_t length;
 
 
@@ -73,11 +69,11 @@ JS_DEFINE_NATIVE_FUNCTION(ArrayIteratorPrototype::next)
     }
     }
 
 
     if (index >= length) {
     if (index >= length) {
-        iterator.m_array = js_undefined();
+        iterator->m_array = js_undefined();
         return create_iterator_result_object(global_object, js_undefined(), true);
         return create_iterator_result_object(global_object, js_undefined(), true);
     }
     }
 
 
-    iterator.m_index++;
+    iterator->m_index++;
     if (iteration_kind == Object::PropertyKind::Key)
     if (iteration_kind == Object::PropertyKind::Key)
         return create_iterator_result_object(global_object, Value(static_cast<i32>(index)), false);
         return create_iterator_result_object(global_object, Value(static_cast<i32>(index)), false);
 
 

+ 4 - 3
Userland/Libraries/LibJS/Runtime/ArrayIteratorPrototype.h

@@ -6,12 +6,13 @@
 
 
 #pragma once
 #pragma once
 
 
-#include <LibJS/Runtime/Object.h>
+#include <LibJS/Runtime/ArrayIterator.h>
+#include <LibJS/Runtime/PrototypeObject.h>
 
 
 namespace JS {
 namespace JS {
 
 
-class ArrayIteratorPrototype final : public Object {
-    JS_OBJECT(ArrayIteratorPrototype, Object)
+class ArrayIteratorPrototype final : public PrototypeObject<ArrayIteratorPrototype, ArrayIterator> {
+    JS_PROTOTYPE_OBJECT(ArrayIteratorPrototype, ArrayIterator, ArrayIterator);
 
 
 public:
 public:
     ArrayIteratorPrototype(GlobalObject&);
     ArrayIteratorPrototype(GlobalObject&);