0ct0pu5/ladybird
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions 2

LibWeb: Set response header cookies on redirects

Browse source 
Since we were previously relying on Document::set_cookie in order to
set cookies received as a 'Set-Cookie' response header, we would ignore
any response header cookies in redirect (status code 3xx) responses.

While this behaviour is not strictly enforced in the specification,
most major browsers do set cookies in redirect responses, and some
sites (e.g. Cookie Clicker) rely on this behaviour.

Since cookies are stored per-site and not per-document, this behaviour
is achieved by simply decoupling the cookie set mechanism from it.
This commit is contained in:
Idan Horowitz 2022-02-12 16:02:56 +02:00 • committed by Linus Groh
parent 5e5b94a7ec
commit 497dd5b354
Notes: sideshowbarker 2024-07-17 23:07:41 +09:00
2 changed files with 26 additions and 10 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

34
Userland/Libraries/LibWeb/Loader/FrameLoader.cpp
View file

@ -11,6 +11,7 @@
#include <LibGemini/Document.h>
#include <LibGfx/ImageDecoder.h>
#include <LibMarkdown/Document.h>
#include <LibWeb/Cookie/ParsedCookie.h>
#include <LibWeb/DOM/Document.h>
#include <LibWeb/DOM/ElementFactory.h>
#include <LibWeb/DOM/Text.h>
@ -253,10 +254,33 @@ void FrameLoader::load_favicon(RefPtr<Gfx::Bitmap> bitmap)
}
}
void FrameLoader::store_response_cookies(AK::URL const& url, String const& cookies)
{
auto* page = browsing_context().page();
if (!page)
return;
auto set_cookie_json_value = MUST(JsonValue::from_string(cookies));
VERIFY(set_cookie_json_value.type() == JsonValue::Type::Array);
for (const auto& set_cookie_entry : set_cookie_json_value.as_array().values()) {
VERIFY(set_cookie_entry.type() == JsonValue::Type::String);
auto cookie = Cookie::parse_cookie(set_cookie_entry.as_string());
if (!cookie.has_value())
continue;
page->client().page_did_set_cookie(url, cookie.value(), Cookie::Source::Http); // FIXME: Determine cookie source correctly
}
}
void FrameLoader::resource_did_load()
{
auto url = resource()->url();
if (auto set_cookie = resource()->response_headers().get("Set-Cookie"); set_cookie.has_value())
store_response_cookies(url, *set_cookie);
// For 3xx (Redirection) responses, the Location value refers to the preferred target resource for automatically redirecting the request.
auto status_code = resource()->status_code();
if (status_code.has_value() && *status_code >= 300 && *status_code <= 399) {
@ -297,16 +321,6 @@ void FrameLoader::resource_did_load()
return;
}
auto set_cookie = resource()->response_headers().get("Set-Cookie");
if (set_cookie.has_value()) {
auto set_cookie_json_value = MUST(JsonValue::from_string(set_cookie.value()));
VERIFY(set_cookie_json_value.type() == JsonValue::Type::Array);
for (const auto& set_cookie_entry : set_cookie_json_value.as_array().values()) {
VERIFY(set_cookie_entry.type() == JsonValue::Type::String);
document->set_cookie(set_cookie_entry.as_string(), Cookie::Source::Http);
}
}
if (!url.fragment().is_empty())
browsing_context().scroll_to_anchor(url.fragment());
else

2
Userland/Libraries/LibWeb/Loader/FrameLoader.h
View file

@ -43,6 +43,8 @@ private:
void load_favicon(RefPtr<Gfx::Bitmap> bitmap = nullptr);
bool parse_document(DOM::Document&, const ByteBuffer& data);
void store_response_cookies(AK::URL const& url, String const& cookies);
HTML::BrowsingContext& m_browsing_context;
size_t m_redirects_count { 0 };
};