We use cookies to ensure you get the best experience on our website
Home Esplora Aiuto
Registrati Accedi
0ct0pu5
/
ladybird
1
0
Forka 0
File Problemi 0 Pull Requests 0 Wiki
Sfoglia il codice sorgente

LibWeb: Make `CSSConditionRule.conditionText` read-only

Previously @media rule conditions could be updated by assigning to
`conditionText`. This change aligns our implementation with the CSSOM
specification, which says `CSSConditionRule.conditionText` should be
read-only.
Tim Ledbetter 1 anno fa
parent
b08fd1b9ae
commit
4646a87eba
8 ha cambiato i file con 29 aggiunte e 15 eliminazioni
Visualizzazione separata Mostra Diff Stats
  1. 4 0
      Tests/LibWeb/Text/expected/css/CSSConditionRule-conditionText-readonly.txt
  2. 24 0
      Tests/LibWeb/Text/input/css/CSSConditionRule-conditionText-readonly.html
  3. 0 1
      Userland/Libraries/LibWeb/CSS/CSSConditionRule.h
  4. 1 1
      Userland/Libraries/LibWeb/CSS/CSSConditionRule.idl
  5. 0 5
      Userland/Libraries/LibWeb/CSS/CSSMediaRule.cpp
  6. 0 1
      Userland/Libraries/LibWeb/CSS/CSSMediaRule.h
  7. 0 6
      Userland/Libraries/LibWeb/CSS/CSSSupportsRule.cpp
  8. 0 1
      Userland/Libraries/LibWeb/CSS/CSSSupportsRule.h

+ 4 - 0
Tests/LibWeb/Text/expected/css/CSSConditionRule-conditionText-readonly.txt
Vedi File 

@@ -0,0 +1,4 @@
 
+   @media rule conditionText initial value: not all
 
+@media rule conditionText value after assignment: not all
 
+@supports rule conditionText initial value: not (unsupported-property: unsupported-value)
 
+@supports rule conditionText value after assignment: not (unsupported-property: unsupported-value)

+ 24 - 0
Tests/LibWeb/Text/input/css/CSSConditionRule-conditionText-readonly.html
Vedi File 

@@ -0,0 +1,24 @@
 
+<!DOCTYPE html>
 
+<style>
 
+    @media not all {
 
+      div { color: red; }
 
+    }
 
+    @supports not (unsupported-property: unsupported-value) {
 
+        div { display: none; }
 
+    }
 
+</style>
 
+<div>This text shouldn't be visible</div>
 
+<script src="../include.js"></script>
 
+<script>
 
+    test(() => {
 
+        const mediaRule = document.styleSheets[0].cssRules[0];
 
+        println(`@media rule conditionText initial value: ${mediaRule.conditionText}`);
 
+        mediaRule.conditionText = "all";
 
+        println(`@media rule conditionText value after assignment: ${mediaRule.conditionText}`);
 
+
 
+        const supportsRule = document.styleSheets[0].cssRules[1];
 
+        println(`@supports rule conditionText initial value: ${supportsRule.conditionText}`);
 
+        mediaRule.conditionText = "(unsupported-property: unsupported-value)";
 
+        println(`@supports rule conditionText value after assignment: ${supportsRule.conditionText}`);
 
+    });
 
+</script>

+ 0 - 1
Userland/Libraries/LibWeb/CSS/CSSConditionRule.h
Vedi File 

@@ -19,7 +19,6 @@ public:
 
     virtual ~CSSConditionRule() = default;
 
 
     virtual String condition_text() const = 0;
 
-    virtual void set_condition_text(String const&) = 0;
 
     virtual bool condition_matches() const = 0;
 
 
     virtual void for_each_effective_style_rule(Function<void(CSSStyleRule const&)> const& callback) const override;

+ 1 - 1
Userland/Libraries/LibWeb/CSS/CSSConditionRule.idl
Vedi File 

@@ -3,5 +3,5 @@
 
 // https://drafts.csswg.org/css-conditional-3/#the-cssconditionrule-interface
 
 [Exposed=Window]
 
 interface CSSConditionRule : CSSGroupingRule {
 
-    attribute CSSOMString conditionText;
 
+    readonly attribute CSSOMString conditionText;
 
 };

+ 0 - 5
Userland/Libraries/LibWeb/CSS/CSSMediaRule.cpp
Vedi File 

@@ -42,11 +42,6 @@ String CSSMediaRule::condition_text() const
 
     return m_media->media_text();
 
 }
 
 
-void CSSMediaRule::set_condition_text(String const& text)
 
-{
 
-    m_media->set_media_text(text);
 
-}
 
-
 
 // https://www.w3.org/TR/cssom-1/#serialize-a-css-rule
 
 String CSSMediaRule::serialized() const
 
 {

+ 0 - 1
Userland/Libraries/LibWeb/CSS/CSSMediaRule.h
Vedi File 

@@ -26,7 +26,6 @@ public:
 
     virtual Type type() const override { return Type::Media; }
 
 
     virtual String condition_text() const override;
 
-    virtual void set_condition_text(String const&) override;
 
     virtual bool condition_matches() const override { return m_media->matches(); }
 
 
     MediaList* media() const { return m_media; }

+ 0 - 6
Userland/Libraries/LibWeb/CSS/CSSSupportsRule.cpp
Vedi File 

@@ -35,12 +35,6 @@ String CSSSupportsRule::condition_text() const
 
     return m_supports->to_string();
 
 }
 
 
-void CSSSupportsRule::set_condition_text(String const& text)
 
-{
 
-    if (auto new_supports = parse_css_supports(Parser::ParsingContext { realm() }, text))
 
-        m_supports = new_supports.release_nonnull();
 
-}
 
-
 
 // https://www.w3.org/TR/cssom-1/#serialize-a-css-rule
 
 String CSSSupportsRule::serialized() const
 
 {

+ 0 - 1
Userland/Libraries/LibWeb/CSS/CSSSupportsRule.h
Vedi File 

@@ -27,7 +27,6 @@ public:
 
     virtual Type type() const override { return Type::Supports; }
 
 
     String condition_text() const override;
 
-    void set_condition_text(String const&) override;
 
     virtual bool condition_matches() const override { return m_supports->matches(); }
 
 
 private:

Contact | Legal | Takedown | Status
Self-hosted public services - About
NibbleSpot by 0ct0pu5