0ct0pu5/ladybird
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions 2

HackStudio: Remove program name element in Core::command() calls

Browse source 
Core::command() takes care of inserting the program name as the first
element in argv, and so we shouldn't include the program name in the
argument vector we give it.

The Shell's argument parsing logic tolerated the extra argument,
until 83609ad.

This fixes building serenity components in Hack Studio.
This commit is contained in:
Itamar 2022-03-16 21:56:58 +02:00 • committed by Ali Mohammad Pur
parent f27c48d707
commit 45788d030a
Notes: sideshowbarker 2024-07-17 17:15:59 +09:00
1 changed files with 2 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
Userland/DevTools/HackStudio/ProjectBuilder.cpp
View file

@ -185,7 +185,7 @@ HashMap<String, NonnullOwnPtr<ProjectBuilder::LibraryInfo>> ProjectBuilder::get_
void ProjectBuilder::for_each_library_definition(Function<void(String, String)> func)
{
Vector<String> arguments = { "sh", "-c", "find Userland/Libraries -name CMakeLists.txt | xargs grep serenity_lib" };
Vector<String> arguments = { "-c", "find Userland/Libraries -name CMakeLists.txt | xargs grep serenity_lib" };
auto res = Core::command("/bin/sh", arguments, {});
if (res.is_error()) {
warnln("{}", res.error());
@ -212,7 +212,7 @@ void ProjectBuilder::for_each_library_definition(Function<void(String, String)>
void ProjectBuilder::for_each_library_dependencies(Function<void(String, Vector<StringView>)> func)
{
Vector<String> arguments = { "sh", "-c", "find Userland/Libraries -name CMakeLists.txt | xargs grep target_link_libraries" };
Vector<String> arguments = { "-c", "find Userland/Libraries -name CMakeLists.txt | xargs grep target_link_libraries" };
auto res = Core::command("/bin/sh", arguments, {});
if (res.is_error()) {
warnln("{}", res.error());