0ct0pu5/ladybird
1
0
Fork 0
mirror of https://github.com/LadybirdBrowser/ladybird.git synced 2024-12-15 19:21:38 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 7

LibJS: Throw TypeError when coercing symbol to number

Browse source
This commit is contained in:
Linus Groh 2020-05-18 00:54:10 +01:00 committed by Andreas Kling
parent 476094922b
commit 4569e88bea
Notes: sideshowbarker 2024-07-19 06:32:18 +09:00 
Author: https://github.com/linusg
Commit: https://github.com/SerenityOS/serenity/commit/4569e88bea5
Pull-request: https://github.com/SerenityOS/serenity/pull/2270
Issue: https://github.com/SerenityOS/serenity/issues/2267
2 changed files with 8 additions and 9 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
Libraries/LibJS/Runtime/Value.cpp
View file

@ -231,8 +231,8 @@ Value Value::to_number(Interpreter& interpreter) const
return Value(parsed_double);
}
case Type::Symbol:
// FIXME: Get access to the interpreter and throw a TypeError
ASSERT_NOT_REACHED();
interpreter.throw_exception<TypeError>("Can't convert symbol to number");
return {};
case Type::Object:
auto primitive = m_value.as_object->to_primitive(Object::PreferredType::Number);
if (interpreter.exception())

13
Libraries/LibJS/Tests/Symbol.prototype.toString.js
View file

@ -14,13 +14,12 @@ try {
message: "Can't convert symbol to string",
});
// FIXME: Uncomment when this doesn't assert
// assertThrowsError(() => {
// s1 + 1;
// }, {
// error: TypeError,
// message: "Can't convert symbol to number",
// });
assertThrowsError(() => {
s1 + 1;
}, {
error: TypeError,
message: "Can't convert symbol to number",
});
console.log("PASS");
} catch (e) {