Prechádzať zdrojové kódy

Profiler: Make processes selectable in the timeline view

Gunnar Beutner 4 rokov pred
rodič
commit
43b3fd748a

+ 26 - 3
Userland/DevTools/Profiler/TimelineHeader.cpp

@@ -6,19 +6,24 @@
 
 #include "TimelineHeader.h"
 #include "Process.h"
+#include "Profile.h"
 #include <AK/LexicalPath.h>
 #include <LibGUI/FileIconProvider.h>
 #include <LibGUI/Icon.h>
 #include <LibGUI/Painter.h>
+#include <LibGfx/Font.h>
+#include <LibGfx/Palette.h>
 
 namespace Profiler {
 
-TimelineHeader::TimelineHeader(Process const& process)
-    : m_process(process)
+TimelineHeader::TimelineHeader(Profile& profile, Process const& process)
+    : m_profile(profile)
+    , m_process(process)
 {
     set_frame_shape(Gfx::FrameShape::Panel);
     set_frame_shadow(Gfx::FrameShadow::Raised);
     set_fixed_size(200, 40);
+    update_selection();
 
     m_icon = GUI::FileIconProvider::icon_for_executable(m_process.executable).bitmap_for_size(32);
     m_text = String::formatted("{} ({})", LexicalPath(m_process.executable).basename(), m_process.pid);
@@ -34,6 +39,8 @@ void TimelineHeader::paint_event(GUI::PaintEvent& event)
     GUI::Painter painter(*this);
     painter.add_clip_rect(event.rect());
 
+    painter.fill_rect(frame_inner_rect(), m_selected ? palette().selection() : palette().button());
+
     Gfx::IntRect icon_rect { frame_thickness() + 2, 0, 32, 32 };
     icon_rect.center_vertically_within(frame_inner_rect());
 
@@ -48,7 +55,23 @@ void TimelineHeader::paint_event(GUI::PaintEvent& event)
     };
     text_rect.center_vertically_within(frame_inner_rect());
 
-    painter.draw_text(text_rect, m_text, Gfx::TextAlignment::CenterLeft);
+    auto& font = m_selected ? painter.font().bold_variant() : painter.font();
+    auto color = m_selected ? palette().selection_text() : palette().button_text();
+    painter.draw_text(text_rect, m_text, font, Gfx::TextAlignment::CenterLeft, color);
+}
+
+void TimelineHeader::update_selection()
+{
+    m_selected = m_profile.has_process_filter() && m_profile.process_filter_contains(m_process.pid, m_process.start_valid);
+    update();
+}
+
+void TimelineHeader::mousedown_event(GUI::MouseEvent& event)
+{
+    if (event.button() != GUI::MouseButton::Left)
+        return;
+    m_selected = !m_selected;
+    on_selection_change(m_selected);
 }
 
 }

+ 9 - 1
Userland/DevTools/Profiler/TimelineHeader.h

@@ -10,6 +10,7 @@
 
 namespace Profiler {
 
+class Profile;
 class Process;
 
 class TimelineHeader final : public GUI::Frame {
@@ -18,14 +19,21 @@ class TimelineHeader final : public GUI::Frame {
 public:
     virtual ~TimelineHeader();
 
+    Function<void(bool)> on_selection_change;
+
+    void update_selection();
+
 private:
-    TimelineHeader(Process const&);
+    TimelineHeader(Profile& profile, Process const&);
 
     virtual void paint_event(GUI::PaintEvent&) override;
+    virtual void mousedown_event(GUI::MouseEvent&) override;
 
+    Profile& m_profile;
     Process const& m_process;
     RefPtr<Gfx::Bitmap> m_icon;
     String m_text;
+    bool m_selected;
 };
 
 }

+ 14 - 1
Userland/DevTools/Profiler/main.cpp

@@ -105,7 +105,20 @@ int main(int argc, char** argv)
         }
         if (!event_count)
             continue;
-        timeline_header_container->add<TimelineHeader>(process);
+        auto& timeline_header = timeline_header_container->add<TimelineHeader>(*profile, process);
+        timeline_header.set_shrink_to_fit(true);
+        timeline_header.on_selection_change = [&](bool selected) {
+            if (selected) {
+                auto end_valid = process.end_valid == 0 ? profile->last_timestamp() : process.end_valid;
+                profile->set_process_filter(process.pid, process.start_valid, end_valid);
+            } else
+                profile->clear_process_filter();
+
+            timeline_header_container->for_each_child_widget([](auto& other_timeline_header) {
+                static_cast<TimelineHeader&>(other_timeline_header).update_selection();
+                return IterationDecision::Continue;
+            });
+        };
         timeline_view->add<TimelineTrack>(*timeline_view, *profile, process);
     }