0ct0pu5/ladybird
1
0
Fork 0
mirror of https://github.com/LadybirdBrowser/ladybird.git synced 2024-12-03 21:10:30 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 10

LibGL: Implement glCompileShader

Browse source
This commit is contained in:
Stephan Unverwerth 2022-08-28 11:19:36 +02:00 committed by Andrew Kaster
parent d5277ecdfe
commit 42ef5c9e12
Notes: sideshowbarker 2024-07-17 03:02:19 +09:00 
Author: https://github.com/sunverwerth
Commit: https://github.com/SerenityOS/serenity/commit/42ef5c9e12
Pull-request: https://github.com/SerenityOS/serenity/pull/16225
Reviewed-by: https://github.com/ADKaster ✅
Reviewed-by: https://github.com/gmta ✅
Reviewed-by: https://github.com/supercomputer7
2 changed files with 8 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

8
Userland/Libraries/LibGL/Shader.cpp
View file

@ -62,8 +62,12 @@ void GLContext::gl_shader_source(GLuint shader, GLsizei count, GLchar const** st
void GLContext::gl_compile_shader(GLuint shader)
{
dbgln("gl_compile_shader({}) unimplemented ", shader);
TODO();
auto it = m_allocated_shaders.find(shader);
// FIXME: implement check "GL_INVALID_VALUE is generated if shader is not a value generated by OpenGL."
RETURN_WITH_ERROR_IF(it == m_allocated_shaders.end(), GL_INVALID_OPERATION);
// NOTE: We are ignoring the compilation result here since it is tracked inside the shader object
(void)it->value->compile();
}
GLuint GLContext::gl_create_program()

2
Userland/Libraries/LibGL/Shaders/Shader.h
View file

@ -24,6 +24,7 @@ public:
ErrorOr<void> add_source(StringView source_code);
ErrorOr<void> compile();
GLenum type() const { return m_type; }
bool compile_status() const { return m_compile_status; }
private:
explicit Shader(GLenum shader_type)
@ -33,6 +34,7 @@ private:
Vector<String> m_sources;
GLenum m_type;
bool m_compile_status { false };
};
}