Sfoglia il codice sorgente

Browser: Rejig the "on_load_counter_change" hook when switching tabs

This feels a little shoddy, but we need to make sure that updates end
up on the right statusbar (since there is one statusbar per tab.)
Andreas Kling 5 anni fa
parent
commit
421619fe2f
1 ha cambiato i file con 8 aggiunte e 8 eliminazioni
  1. 8 8
      Applications/Browser/Tab.cpp

+ 8 - 8
Applications/Browser/Tab.cpp

@@ -163,14 +163,6 @@ Tab::Tab()
         m_statusbar->set_text(href);
     };
 
-    Web::ResourceLoader::the().on_load_counter_change = [this] {
-        if (Web::ResourceLoader::the().pending_loads() == 0) {
-            m_statusbar->set_text("");
-            return;
-        }
-        m_statusbar->set_text(String::format("Loading (%d pending resources...)", Web::ResourceLoader::the().pending_loads()));
-    };
-
     m_menubar = GUI::MenuBar::construct();
 
     auto& app_menu = m_menubar->add_menu("Browser");
@@ -286,6 +278,14 @@ void Tab::update_bookmark_button(const String& url)
 
 void Tab::did_become_active()
 {
+    Web::ResourceLoader::the().on_load_counter_change = [this] {
+        if (Web::ResourceLoader::the().pending_loads() == 0) {
+            m_statusbar->set_text("");
+            return;
+        }
+        m_statusbar->set_text(String::format("Loading (%d pending resources...)", Web::ResourceLoader::the().pending_loads()));
+    };
+
     BookmarksBarWidget::the().on_bookmark_click = [this](auto&, auto& url) {
         m_html_widget->load(url);
     };