0ct0pu5/ladybird
1
0
Fork 0
mirror of https://github.com/LadybirdBrowser/ladybird.git synced 2024-12-04 05:20:30 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 7

AK: Remove String <-> char const* comparison operators

Browse source 
During the removal of StringView(char const*), all users of these
functions were removed, and they are of dubious value (relying on
implicit StringView conversion).
This commit is contained in:
sin-ack 2022-07-11 20:54:28 +00:00 committed by Andreas Kling
parent 5422691f07
commit 3f8060d859
Notes: sideshowbarker 2024-07-17 09:26:43 +09:00 
Author: https://github.com/sin-ack
Commit: https://github.com/SerenityOS/serenity/commit/3f8060d859
Pull-request: https://github.com/SerenityOS/serenity/pull/14555
Reviewed-by: https://github.com/Dexesttp ✅
Reviewed-by: https://github.com/kleinesfilmroellchen
2 changed files with 0 additions and 25 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

20
AK/String.cpp
View file

@ -393,26 +393,6 @@ String String::invert_case() const
return StringUtils::invert_case(*this);
}
bool operator<(char const* characters, String const& string)
{
return string.view() > characters;
}
bool operator>=(char const* characters, String const& string)
{
return string.view() <= characters;
}
bool operator>(char const* characters, String const& string)
{
return string.view() < characters;
}
bool operator<=(char const* characters, String const& string)
{
return string.view() >= characters;
}
bool String::operator==(char const* cstring) const
{
return view() == cstring;

5
AK/String.h
View file

@ -327,11 +327,6 @@ struct CaseInsensitiveStringTraits : public Traits<String> {
static bool equals(String const& a, String const& b) { return a.equals_ignoring_case(b); }
};
bool operator<(char const*, String const&);
bool operator>=(char const*, String const&);
bool operator>(char const*, String const&);
bool operator<=(char const*, String const&);
String escape_html_entities(StringView html);
InputStream& operator>>(InputStream& stream, String& string);