Browse Source

Kernel: Unnamed regions still need a null-terminator in core dumps

Fixes #7595.
Andreas Kling 4 years ago
parent
commit
3e0266c9e9
1 changed files with 5 additions and 1 deletions
  1. 5 1
      Kernel/CoreDump.cpp

+ 5 - 1
Kernel/CoreDump.cpp

@@ -247,8 +247,12 @@ ByteBuffer CoreDump::create_notes_regions_data() const
         memory_region_info_buffer.append((void*)&info, sizeof(info));
         // NOTE: The region name *is* null-terminated, so the following is ok:
         auto name = region->name();
-        if (!name.is_null())
+        if (name.is_empty()) {
+            char null_terminator = '\0';
+            memory_region_info_buffer.append(&null_terminator, 1);
+        } else {
             memory_region_info_buffer.append(name.characters_without_null_termination(), name.length() + 1);
+        }
 
         regions_data += memory_region_info_buffer;
     }