LibJS: Explicitly disallow references in ThrowCompletionOr

This will be disallowed by TRY soon, but the compile error produced by this requirement will pinpoint the errant line more accurately.
Author: https://github.com/trflynn89 Commit: https://github.com/SerenityOS/serenity/commit/3de75f6436 Pull-request: https://github.com/SerenityOS/serenity/pull/16999 Reviewed-by: https://github.com/alimpfard ✅ Reviewed-by: https://github.com/linusg ✅
2023-01-13 15:45:04 -05:00 · 2023-01-13 15:45:04 -05:00 · 3de75f6436 · 2024-07-17 03:03:37 +09:00
commit 3de75f6436
parent a59ebdac2d
2 changed files with 3 additions and 0 deletions
--- a/Userland/Libraries/LibJS/Forward.h
+++ b/Userland/Libraries/LibJS/Forward.h
@ -7,6 +7,7 @@

 #pragma once

+#include <AK/Concepts.h>
 #include <AK/Types.h>

 #define JS_DECLARE_NATIVE_FUNCTION(name) \
@ -282,6 +283,7 @@ struct PartialDurationRecord;
 };

 template<typename T>
+requires(!IsLvalueReference<T>)
 class ThrowCompletionOr;

 template<class T>
--- a/Userland/Libraries/LibJS/Runtime/Completion.h
+++ b/Userland/Libraries/LibJS/Runtime/Completion.h
@ -246,6 +246,7 @@ private:
 namespace JS {

 template<typename ValueType>
+requires(!IsLvalueReference<ValueType>)
 class [[nodiscard]] ThrowCompletionOr {
 public:
    ThrowCompletionOr()