Преглед на файлове

LibWeb: Do not try to join floats into anonymous block

Making floats to join anonymous block caused regressions in
Acid2 Test so let's leave it to be only absolute blocks who
might be joined into anonymous block when possible.
Aliaksandr Kalenik преди 2 години
родител
ревизия
3d74d72bcb
променени са 1 файла, в които са добавени 3 реда и са изтрити 4 реда
  1. 3 4
      Userland/Libraries/LibWeb/Layout/TreeBuilder.cpp

+ 3 - 4
Userland/Libraries/LibWeb/Layout/TreeBuilder.cpp

@@ -84,11 +84,10 @@ static Layout::Node& insertion_parent_for_block_node(Layout::NodeWithStyle& layo
         return layout_parent;
         return layout_parent;
     }
     }
 
 
-    if (layout_node.is_floating() || layout_node.is_absolutely_positioned()) {
+    // TODO: Floats should probably also be able to have inline siblings
+    if (layout_node.is_absolutely_positioned() && layout_parent.last_child()->children_are_inline()) {
         // Block is out-of-flow, it can have inline siblings if necessary.
         // Block is out-of-flow, it can have inline siblings if necessary.
-        if (layout_parent.last_child()->children_are_inline()) {
-            return *layout_parent.last_child();
-        }
+        return *layout_parent.last_child();
     }
     }
 
 
     if (!layout_parent.children_are_inline()) {
     if (!layout_parent.children_are_inline()) {