Taskbar: Check if executable in .af exist in filesystem

This adds access X_OK check in discover_apps_and_categories() to see executable specified in .af files exist before registering them for start menu.
Author: https://github.com/TURING-V2 🔰 Commit: https://github.com/SerenityOS/serenity/commit/3d42297ecdf Pull-request: https://github.com/SerenityOS/serenity/pull/8200 Reviewed-by: https://github.com/awesomekling
2021-06-22 17:30:57 +05:30 · 2021-06-22 17:30:57 +05:30 · 3d42297ecd · 2024-07-18 11:38:57 +09:00
commit 3d42297ecd
parent 8a3c9d9851
1 changed files with 4 additions and 2 deletions
--- a/Userland/Services/Taskbar/main.cpp
+++ b/Userland/Services/Taskbar/main.cpp
@ -87,8 +87,10 @@ Vector<String> discover_apps_and_categories()
 {
    HashTable<String> seen_app_categories;
    Desktop::AppFile::for_each([&](auto af) {
-        g_apps.append({ af->executable(), af->name(), af->category() });
-        seen_app_categories.set(af->category());
+        if (access(af->executable().characters(), X_OK) == 0) {
+            g_apps.append({ af->executable(), af->name(), af->category() });
+            seen_app_categories.set(af->category());
+        }
    });
    quick_sort(g_apps, [](auto& a, auto& b) { return a.name < b.name; });