diff --git a/Userland/Libraries/LibJS/Parser.cpp b/Userland/Libraries/LibJS/Parser.cpp index f4692573def..ac8403ceac9 100644 --- a/Userland/Libraries/LibJS/Parser.cpp +++ b/Userland/Libraries/LibJS/Parser.cpp @@ -1926,7 +1926,7 @@ NonnullRefPtr Parser::parse_object_expression() if (match(TokenType::TripleDot)) { consume(); - property_key = parse_expression(4); + property_key = parse_expression(2); properties.append(create_ast_node({ m_source_code, rule_start.position(), position() }, *property_key, nullptr, ObjectProperty::Type::Spread, false)); if (!match(TokenType::Comma)) break; diff --git a/Userland/Libraries/LibJS/Tests/builtins/Array/array-spread.js b/Userland/Libraries/LibJS/Tests/builtins/Array/array-spread.js index cb570edffe3..ec9546cd28a 100644 --- a/Userland/Libraries/LibJS/Tests/builtins/Array/array-spread.js +++ b/Userland/Libraries/LibJS/Tests/builtins/Array/array-spread.js @@ -23,3 +23,23 @@ test("basic functionality", () => { expect([...[], ...[...[1, 2, 3]], 4]).toEqual([1, 2, 3, 4]); }); + +test("allows assignment expressions", () => { + expect("([ ...a = { hello: 'world' } ])").toEval(); + expect("([ ...a += 'hello' ])").toEval(); + expect("([ ...a -= 'hello' ])").toEval(); + expect("([ ...a **= 'hello' ])").toEval(); + expect("([ ...a *= 'hello' ])").toEval(); + expect("([ ...a /= 'hello' ])").toEval(); + expect("([ ...a %= 'hello' ])").toEval(); + expect("([ ...a <<= 'hello' ])").toEval(); + expect("([ ...a >>= 'hello' ])").toEval(); + expect("([ ...a >>>= 'hello' ])").toEval(); + expect("([ ...a &= 'hello' ])").toEval(); + expect("([ ...a ^= 'hello' ])").toEval(); + expect("([ ...a |= 'hello' ])").toEval(); + expect("([ ...a &&= 'hello' ])").toEval(); + expect("([ ...a ||= 'hello' ])").toEval(); + expect("([ ...a ??= 'hello' ])").toEval(); + expect("function* test() { return ([ ...yield a ]); }").toEval(); +}); diff --git a/Userland/Libraries/LibJS/Tests/object-spread.js b/Userland/Libraries/LibJS/Tests/object-spread.js index 340e04746af..c34f9322264 100644 --- a/Userland/Libraries/LibJS/Tests/object-spread.js +++ b/Userland/Libraries/LibJS/Tests/object-spread.js @@ -172,3 +172,23 @@ describe("modification of spreadable objects during spread", () => { expect(arrayResult).toHaveProperty("1000", 1000); }); }); + +test("allows assignment expressions", () => { + expect("({ ...a = { hello: 'world' } })").toEval(); + expect("({ ...a += 'hello' })").toEval(); + expect("({ ...a -= 'hello' })").toEval(); + expect("({ ...a **= 'hello' })").toEval(); + expect("({ ...a *= 'hello' })").toEval(); + expect("({ ...a /= 'hello' })").toEval(); + expect("({ ...a %= 'hello' })").toEval(); + expect("({ ...a <<= 'hello' })").toEval(); + expect("({ ...a >>= 'hello' })").toEval(); + expect("({ ...a >>>= 'hello' })").toEval(); + expect("({ ...a &= 'hello' })").toEval(); + expect("({ ...a ^= 'hello' })").toEval(); + expect("({ ...a |= 'hello' })").toEval(); + expect("({ ...a &&= 'hello' })").toEval(); + expect("({ ...a ||= 'hello' })").toEval(); + expect("({ ...a ??= 'hello' })").toEval(); + expect("function* test() { return ({ ...yield a }); }").toEval(); +});