0ct0pu5/ladybird
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions 2

LibWeb: Adjust specified table height

Browse source 
Subtract borders and padding from specified height before comparing to
the used content height.
This commit is contained in:
Andi Gallo 2023-06-25 09:16:34 +00:00 • committed by Andreas Kling
parent 77f1e91e9d
commit 3a0f7e8eb8
Notes: sideshowbarker 2024-07-16 21:42:29 +09:00
2 changed files with 5 additions and 6 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

6
Tests/LibWeb/Layout/expected/table/stretch-to-fixed-height.txt
View file

@ -1,8 +1,8 @@
Viewport <#document> at (0,0) content-size 800x600 children: not-inline
BlockContainer <html> at (0,0) content-size 800x600 [BFC] children: not-inline
BlockContainer <body> at (8,8) content-size 784x122 children: not-inline
TableWrapper <(anonymous)> at (8,8) content-size 24x122 [BFC] children: not-inline
Box <table> at (19,19) content-size 2x100 table-box [TFC] children: not-inline
BlockContainer <body> at (8,8) content-size 784x100 children: not-inline
TableWrapper <(anonymous)> at (8,8) content-size 24x100 [BFC] children: not-inline
Box <table> at (19,19) content-size 2x78 table-box [TFC] children: not-inline
BlockContainer <(anonymous)> (not painted) children: inline
TextNode <#text>
Box <tbody> at (19,19) content-size 0x0 table-row-group children: not-inline

5
Userland/Libraries/LibWeb/Layout/TableFormattingContext.cpp
View file

@ -590,9 +590,8 @@ void TableFormattingContext::compute_table_height(LayoutMode layout_mode)
// ends up smaller than this number.
CSSPixels height_of_table_containing_block = m_state.get(*table_wrapper().containing_block()).content_height();
auto specified_table_height = table_box().computed_values().height().to_px(table_box(), height_of_table_containing_block);
if (m_table_height < specified_table_height) {
m_table_height = specified_table_height;
}
auto const& table_state = m_state.get(table_box());
m_table_height = max(m_table_height, specified_table_height - table_state.border_box_top() - table_state.border_box_bottom());
}
for (auto& row : m_rows) {