0ct0pu5/ladybird
1
0
Fork 0
mirror of https://github.com/LadybirdBrowser/ladybird.git synced 2024-12-04 21:40:33 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 7

LibIMAP: Add a bunch of serialize_astring in command construction

Browse source 
These were putting the raw string values into the command, where they
should be astrings as per the grammar:
https://datatracker.ietf.org/doc/html/rfc3501#section-9
This commit is contained in:
Luke 2021-07-24 18:09:41 +01:00 committed by Linus Groh
parent 6097578c59
commit 3948161c14
Notes: sideshowbarker 2024-07-18 08:23:39 +09:00 
Author: https://github.com/Lubrsi
Commit: https://github.com/SerenityOS/serenity/commit/3948161c142
Pull-request: https://github.com/SerenityOS/serenity/pull/8984
Reviewed-by: https://github.com/linusg ✅
1 changed files with 9 additions and 9 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

18
Userland/Libraries/LibIMAP/Client.cpp
View file

@ -207,7 +207,7 @@ RefPtr<Promise<Optional<T>>> cast_promise(RefPtr<Promise<Optional<Response>>> pr
RefPtr<Promise<Optional<SolidResponse>>> Client::login(StringView username, StringView password)
{
auto command = Command { CommandType::Login, m_current_command, { username, password } };
auto command = Command { CommandType::Login, m_current_command, { serialize_astring(username), serialize_astring(password) } };
return cast_promise<SolidResponse>(send_command(move(command)));
}
@ -241,7 +241,7 @@ RefPtr<Promise<Optional<Response>>> Client::send_simple_command(CommandType type
RefPtr<Promise<Optional<SolidResponse>>> Client::select(StringView string)
{
auto command = Command { CommandType::Select, m_current_command, { string } };
auto command = Command { CommandType::Select, m_current_command, { serialize_astring(string) } };
return cast_promise<SolidResponse>(send_command(move(command)));
}
@ -293,19 +293,19 @@ void Client::send_next_command()
RefPtr<Promise<Optional<SolidResponse>>> Client::examine(StringView string)
{
auto command = Command { CommandType::Examine, m_current_command, { string } };
auto command = Command { CommandType::Examine, m_current_command, { serialize_astring(string) } };
return cast_promise<SolidResponse>(send_command(move(command)));
}
RefPtr<Promise<Optional<SolidResponse>>> Client::create_mailbox(StringView name)
{
auto command = Command { CommandType::Create, m_current_command, { name } };
auto command = Command { CommandType::Create, m_current_command, { serialize_astring(name) } };
return cast_promise<SolidResponse>(send_command(move(command)));
}
RefPtr<Promise<Optional<SolidResponse>>> Client::delete_mailbox(StringView name)
{
auto command = Command { CommandType::Delete, m_current_command, { name } };
auto command = Command { CommandType::Delete, m_current_command, { serialize_astring(name) } };
return cast_promise<SolidResponse>(send_command(move(command)));
}
@ -426,12 +426,12 @@ RefPtr<Promise<Optional<SolidResponse>>> Client::append(StringView mailbox, Mess
}
RefPtr<Promise<Optional<SolidResponse>>> Client::subscribe(StringView mailbox)
{
auto command = Command { CommandType::Subscribe, m_current_command, { mailbox } };
auto command = Command { CommandType::Subscribe, m_current_command, { serialize_astring(mailbox) } };
return cast_promise<SolidResponse>(send_command(move(command)));
}
RefPtr<Promise<Optional<SolidResponse>>> Client::unsubscribe(StringView mailbox)
{
auto command = Command { CommandType::Unsubscribe, m_current_command, { mailbox } };
auto command = Command { CommandType::Unsubscribe, m_current_command, { serialize_astring(mailbox) } };
return cast_promise<SolidResponse>(send_command(move(command)));
}
RefPtr<Promise<Optional<Response>>> Client::authenticate(StringView method)
@ -441,13 +441,13 @@ RefPtr<Promise<Optional<Response>>> Client::authenticate(StringView method)
}
RefPtr<Promise<Optional<SolidResponse>>> Client::rename(StringView from, StringView to)
{
auto command = Command { CommandType::Rename, m_current_command, { from, to } };
auto command = Command { CommandType::Rename, m_current_command, { serialize_astring(from), serialize_astring(to) } };
return cast_promise<SolidResponse>(send_command(move(command)));
}
RefPtr<Promise<Optional<SolidResponse>>> Client::copy(Sequence sequence_set, StringView name, bool uid)
{
auto command = Command {
uid ? CommandType::UIDCopy : CommandType::Copy, m_current_command, { sequence_set.serialize(), name }
uid ? CommandType::UIDCopy : CommandType::Copy, m_current_command, { sequence_set.serialize(), serialize_astring(name) }
};
return cast_promise<SolidResponse>(send_command(move(command)));