0ct0pu5/ladybird
1
0
Fork 0
mirror of https://github.com/LadybirdBrowser/ladybird.git synced 2024-12-03 21:10:30 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 10

AK: Fix formatting of negative whole fixed point numbers

Browse source 
Instead of `-2` we were printing `-2.1`

Co-Authored-By: Daniel Bertalan <dani@danielbertalan.dev>
This commit is contained in:
Hendiadyoin1 2023-07-25 18:08:11 +02:00 committed by Andrew Kaster
parent daacc5c6c2
commit 394529b7d0
Notes: sideshowbarker 2024-07-17 08:59:18 +09:00 
Author: https://github.com/Hendiadyoin1
Commit: https://github.com/SerenityOS/serenity/commit/394529b7d0
Pull-request: https://github.com/SerenityOS/serenity/pull/20163
Reviewed-by: https://github.com/DanShaders
2 changed files with 5 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
AK/Format.cpp
View file

@ -396,7 +396,7 @@ ErrorOr<void> FormatBuilder::put_fixed_point(
u64 scale = pow<u64>(10, precision);
auto fraction = (scale * fraction_value) / fraction_one; // TODO: overflows
if (is_negative)
if (is_negative && fraction != 0)
fraction = scale - fraction;
size_t leading_zeroes = 0;

4
Tests/AK/TestFixedPoint.cpp
View file

@ -178,4 +178,8 @@ TEST_CASE(formatter)
EXPECT_EQ(DeprecatedString::formatted("{}", FixedPoint<16>(-0.1)), "-0.100007"sv);
EXPECT_EQ(DeprecatedString::formatted("{}", FixedPoint<16>(-0.02)), "-0.020005"sv);
EXPECT_EQ(DeprecatedString::formatted("{}", FixedPoint<16>(-0.0000000005)), "0"sv);
EXPECT_EQ(DeprecatedString::formatted("{}", Type(-1)), "-1"sv);
EXPECT_EQ(DeprecatedString::formatted("{}", Type(-2)), "-2"sv);
EXPECT_EQ(DeprecatedString::formatted("{}", Type(-3)), "-3"sv);
}