Browse Source

CrashReporter: Put backtrace TextEditor in a TabWidget

Since CrashReporter will be showing more info from coredumps soon, we
need tabs to put those things somewhere! :^)
Linus Groh 4 years ago
parent
commit
3718a16f59

+ 2 - 15
Userland/Applications/CrashReporter/CrashReporterWindow.gml

@@ -58,21 +58,8 @@
         }
     }
 
-    @GUI::Widget {
-        fixed_height: 18
-
-        layout: @GUI::HorizontalBoxLayout {
-        }
-
-        @GUI::Label {
-            text: "Backtrace:"
-            text_alignment: "CenterLeft"
-        }
-    }
-
-    @GUI::TextEditor {
-        name: "backtrace_text_editor"
-        mode: "ReadOnly"
+    @GUI::TabWidget {
+        name: "tab_widget"
     }
 
     @GUI::Widget {

+ 5 - 1
Userland/Applications/CrashReporter/main.cpp

@@ -43,6 +43,7 @@
 #include <LibGUI/Label.h>
 #include <LibGUI/Layout.h>
 #include <LibGUI/LinkLabel.h>
+#include <LibGUI/TabWidget.h>
 #include <LibGUI/TextEditor.h>
 #include <LibGUI/Window.h>
 #include <string.h>
@@ -163,7 +164,10 @@ int main(int argc, char** argv)
         Desktop::Launcher::open(URL::create_with_file_protocol(LexicalPath(coredump_path).dirname()));
     };
 
-    auto& backtrace_text_editor = *widget.find_descendant_of_type_named<GUI::TextEditor>("backtrace_text_editor");
+    auto& tab_widget = *widget.find_descendant_of_type_named<GUI::TabWidget>("tab_widget");
+
+    auto& backtrace_text_editor = tab_widget.add_tab<GUI::TextEditor>("Backtrace");
+    backtrace_text_editor.set_mode(GUI::TextEditor::Mode::ReadOnly);
     backtrace_text_editor.set_text(backtrace);
     backtrace_text_editor.set_should_hide_unnecessary_scrollbars(true);