From 34dd8edcb3f9b7532b22ab6d41cd9623a791deb6 Mon Sep 17 00:00:00 2001
From: Brian Gianforcaro <b.gianfo@gmail.com>
Date: Sat, 8 Aug 2020 12:29:09 -0700
Subject: [PATCH] Kernel: Decorate KResult and KResultOr<T> methods with
 [[nodiscard]]

This would have found my error propagation bug.
---
 Kernel/KResult.h | 12 ++++++++----
 1 file changed, 8 insertions(+), 4 deletions(-)

diff --git a/Kernel/KResult.h b/Kernel/KResult.h
index 168b2825cee..cb457b09f10 100644
--- a/Kernel/KResult.h
+++ b/Kernel/KResult.h
@@ -47,10 +47,10 @@ public:
     {
     }
     operator int() const { return m_error; }
-    int error() const { return m_error; }
+    [[nodiscard]] int error() const { return m_error; }
 
-    bool is_success() const { return m_error == 0; }
-    bool is_error() const { return !is_success(); }
+    [[nodiscard]] bool is_success() const { return m_error == 0; }
+    [[nodiscard]] bool is_error() const { return !is_success(); }
 
 private:
     template<typename T>
@@ -115,18 +115,22 @@ public:
             value().~T();
     }
 
-    bool is_error() const { return m_is_error; }
+    [[nodiscard]] bool is_error() const { return m_is_error; }
+
     ALWAYS_INLINE KResult error() const
     {
         ASSERT(m_is_error);
         return m_error;
     }
+
     KResult result() const { return m_is_error ? KSuccess : m_error; }
+
     ALWAYS_INLINE T& value()
     {
         ASSERT(!m_is_error);
         return *reinterpret_cast<T*>(&m_storage);
     }
+
     ALWAYS_INLINE const T& value() const
     {
         ASSERT(!m_is_error);